Bug 56255

Summary: qt_runtime fails to compile on Solaris 10/Sun Studio 12 C++
Product: WebKit Reporter: Ben Taylor <bentaylor.solx86>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, tropikhajma
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler none

Ben Taylor
Reported 2011-03-12 12:07:00 PST
Compiling qt-4.7.1 on Solaris 10 with Sun Studio 12 C++, qt_runtime.o fails to build due to the following error: pkgbuild: "bridge/runtime_array.h", line 53: Error: Type name expected instead of "Bindings". pkgbuild: "bridge/runtime_array.h", line 53: Error: Cannot use int* to initialize JSC::Bindings::Array*.
Attachments
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler (1.45 KB, patch)
2011-03-12 12:15 PST, Ben Taylor 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Taylor
Comment 1 2011-03-12 12:15:29 PST
Created attachment 85600 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This patch is on webkit head, but the similar patch on qt-4.7.1 on Solaris 10 with Sun Studio 12 C++ compiles correctly.
Adam Barth
Comment 2 2011-03-15 02:25:24 PDT
Comment on attachment 85600 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Ok. We're likely to break this compile accidentally in the future, however.
WebKit Commit Bot
Comment 3 2011-03-15 03:34:03 PDT
Comment on attachment 85600 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 85600 Committed r81126: <http://trac.webkit.org/changeset/81126>
WebKit Commit Bot
Comment 4 2011-03-15 03:34:07 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5 2011-03-15 05:07:24 PDT
The commit-queue encountered the following flaky tests while processing attachment 85600 [details]: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Pavel Heimlich (hajma)
Comment 6 2011-03-28 10:50:07 PDT
*** Bug 42013 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.