Bug 42669

Summary: WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, cshu, laszlo.gombos, qi.2.zhang, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
fix regression none

Sam Weinig
Reported 2010-07-20 14:33:59 PDT
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
Attachments
patch (10.73 KB, patch)
2011-05-20 13:44 PDT, qi 		no flags
DetailsFormatted DiffDiff
fix regression (3.00 KB, patch)
2011-05-24 09:07 PDT, qi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:33:33 PDT
<rdar://problem/8213875>
qi
Comment 2 2011-05-20 13:44:15 PDT
Created attachment 94265 [details] patch
WebKit Commit Bot
Comment 3 2011-05-23 07:19:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 94265 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-05-23 07:20:45 PDT
Comment on attachment 94265 [details] patch Clearing flags on attachment: 94265 Committed r87072: <http://trac.webkit.org/changeset/87072>
WebKit Commit Bot
Comment 5 2011-05-23 07:20:50 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 6 2011-05-23 10:28:37 PDT
This seems to have caused about 90 new test failures on the SnowLeopard WebKit2 bot. Please investigate.
qi
Comment 7 2011-05-23 10:51:58 PDT
I am investigating..
Chang Shu
Comment 8 2011-05-23 14:55:31 PDT
I was helping Qi a little bit... I updated my webkit revision to r87071 (the one before Qi's commit) and still reproduced 4 failures under execCommand: Testing 219 test cases. editing/execCommand ............... editing/execCommand/4128080-2.html -> failed ........................................................................ editing/execCommand/copy-without-selection.html -> failed ............................................................................................. editing/execCommand/paste-1.html -> failed . editing/execCommand/paste-2.html -> failed ...................................... 4.39s total testing time Probably the regression happened earlier. But the buildbot seemed fine.
Chang Shu
Comment 9 2011-05-24 07:23:25 PDT
(In reply to comment #8) > I was helping Qi a little bit... > I updated my webkit revision to r87071 (the one before Qi's commit) and still reproduced 4 failures under execCommand: > Testing 219 test cases. > editing/execCommand ............... > editing/execCommand/4128080-2.html -> failed > ........................................................................ > editing/execCommand/copy-without-selection.html -> failed > ............................................................................................. > editing/execCommand/paste-1.html -> failed > . > editing/execCommand/paste-2.html -> failed > ...................................... > 4.39s total testing time > > Probably the regression happened earlier. But the buildbot seemed fine. Please ignore the above comments. It was run in a "su [user]" environment and somehow it didn't generate the correct results. By switching to right user, the problem was successfully reproduced and verified. Qi's working on a patch. Should be soon.
qi
Comment 10 2011-05-24 09:07:48 PDT
Created attachment 94623 [details] fix regression Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed. Because that case changed the setting.
Adam Roben (:aroben)
Comment 11 2011-05-24 10:14:36 PDT
Comment on attachment 94623 [details] fix regression Marking cq+ as I don't believe Qi Zhang is a committer. (In the future, you should mark your patches cq? to indicate that you want them to be committed once they are reviewed.)
Adam Roben (:aroben)
Comment 12 2011-05-24 10:33:42 PDT
Reopening the bug so the commit-queue will see the patch.
WebKit Commit Bot
Comment 13 2011-05-24 11:39:16 PDT
Comment on attachment 94623 [details] fix regression Clearing flags on attachment: 94623 Committed r87175: <http://trac.webkit.org/changeset/87175>
WebKit Commit Bot
Comment 14 2011-05-24 11:39:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.