Bug 32936

Summary:

HTML5 <section> element support

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mjs, sam, webkit.review.bot, webmaster

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://www.whatwg.org/specs/web-apps/current-work/multipage/sections.html#the-section-element

Bug Depends on:

Bug Blocks:

32934

Attachments:

Description	Flags
Proposed patch	darin: review+

Kent Tamura

Reported 2009-12-25 11:07:26 PST

Implement <section> element. It should be very similar to <nav> we already have.

Attachments
Proposed patch (10.46 KB, patch) 2009-12-25 11:17 PST, Kent Tamura	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2009-12-25 11:17:21 PST

Created attachment 45494 [details] Proposed patch The patch is very similar to http://trac.webkit.org/changeset/47489 for <nav>.

WebKit Review Bot

Comment 2 2009-12-25 11:19:06 PST

style-queue ran check-webkit-style on attachment 45494 [details] without any errors.

Darin Adler

Comment 3 2009-12-25 20:18:17 PST

Comment on attachment 45494 [details] Proposed patch > +debug('<section> can be nest nested inside <section>:'); Looks like "nest" here is an extra word.

Kent Tamura

Comment 4 2009-12-25 21:30:15 PST

(In reply to comment #3) > (From update of attachment 45494 [details]) > > +debug('<section> can be nest nested inside <section>:'); > > Looks like "nest" here is an extra word. Right! Removed and reset the expected result. Landed as r52564: <http://trac.webkit.org/changeset/52564>

Lars Gunther

Comment 5 2010-04-03 02:30:45 PDT

As far as I can tell, this bug did not include the actual sectioning behaviour? I.e. <h1>foo</h1> <p>Lorem</p> <section> <h1>bar</h1> <p>Lorem</p> </section> Should be functionally equivalent to: <h1>Foo</h1> <p>Lorem</p> <h2>Bar</h2> <p>Lorem</p> I see no open bug about sectioning. Should one be opened?

Kent Tamura

Comment 6 2010-04-03 03:09:23 PDT

(In reply to comment #5) > As far as I can tell, this bug did not include the actual sectioning behaviour? What part of the HTML5 spec are you talking about?

Lars Gunther

Comment 7 2010-04-03 09:32:37 PDT

Sectioning is described here: http://dev.w3.org/html5/spec/dom.html#sectioning-content-0 http://dev.w3.org/html5/spec/semantics.html#headings-and-sections We also have this unofficial resource: http://gsnedders.html5.org/outliner/

Kent Tamura

Comment 8 2010-04-05 02:28:18 PDT

(In reply to comment #7) Two fragments in Comment #5 are equivalent in the outline algorithm, and they should not be equivalent as DOM trees. I don't know we have reasons to implement the outline algorithm in WebKit.

Lars Gunther

Comment 9 2010-04-05 05:34:07 PDT

(In reply to comment #8) > Two fragments in Comment #5 are equivalent in the outline algorithm, and they > should not be equivalent as DOM trees. > I don't know we have reasons to implement the outline algorithm in WebKit. It's not about the DOM tree, since they should not be equivalent. But it is about semantics and thus about accessibility and default styling. When users jump between headings in programs like JAWS, an H1 within a section is not equal to an H1 outside of it. Also, H1 within a section should probably not have the same default styling as an H1 outside of it.

Note You need to log in before you can comment on or make changes to this bug.