Bug 282306

Summary: leagueoflegends.com: misaligned checkbox on sign in page (Stayed Signed in)
Product: WebKit Reporter: Sammy Gill <sgill26>
Component: Layout and RenderingAssignee: Sammy Gill <sgill26>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: annevk, bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Reduced testcase none

Sammy Gill
Reported 2024-10-29 17:18:28 PDT
1. Go to: https://authenticate.riotgames.com/ 2. Look at `stayed signed in` (checkbox)
Attachments
Reduced testcase (433 bytes, text/html)
2024-11-20 02:48 PST, Anne van Kesteren 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Sammy Gill
Comment 1 2024-10-29 17:18:47 PDT
rdar://138040835
Sammy Gill
Comment 2 2024-10-30 10:56:06 PDT
I reduced the the page down to a test case where we were incorrectly sizing a SVG but fixing that still does not resolve the issue so maybe there are a couple of different issues occurring or not quite the correct test case reduction
Anne van Kesteren
Comment 3 2024-11-20 02:48:03 PST
Created attachment 473292 [details] Reduced testcase
Anne van Kesteren
Comment 4 2024-11-20 02:50:16 PST
Per my reduced testcase the difference between WebKit and other engines seems to be related to the inline-flex display value. I hope that helps you solve this.
Anne van Kesteren
Comment 5 2024-11-20 04:20:22 PST
The problem is also addressed when I add height=20 width=20 to the <svg> start tag, which does suggest it's more related to the SVG. And in particular when the SVG is a child of a display:flex element there's a difference between WebKit and other engines: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/13277
Sammy Gill
Comment 6 2024-12-10 13:42:40 PST
Pull request: https://github.com/WebKit/WebKit/pull/37735
Sammy Gill
Comment 7 2024-12-10 13:45:18 PST
I believe this is actually a dupe of another bug according to our test case reductions. Fixing the bug on the site happened to cause a WPT to start passing which is likely the same issue. *** This bug has been marked as a duplicate of bug 221474 ***
Note You need to log in before you can comment on or make changes to this bug.