Bug 280875
Summary: | [Win] disassembler/zydis/Zydis/ZydisSharedData.c(180,25): error: comparison of integers of different signs: 'ZydisInternalElementType' (aka 'enum ZydisInternalElementType_') and 'unsigned long long' [-Werror,-Wsign-compare] | ||
---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <fujii.hironori> |
Component: | JavaScriptCore | Assignee: | Fujii Hironori <fujii.hironori> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Fujii Hironori
After 284574@main, Windows port Debug build can compile.
[5/5304] Building C object Source\JavaScriptCore\CMakeFiles\JavaScriptCor...criptCore\DerivedSources\unified-sources\UnifiedSource-fa42537c-2-c.c.obj
FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-fa42537c-2-c.c.obj
C:\PROGRA~1\LLVM\bin\clang-cl.exe (...) -c -- C:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-fa42537c-2-c.c
In file included from C:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-fa42537c-2-c.c:8:
C:\webkit\wb\Source\JavaScriptCore\disassembler/zydis/Zydis/ZydisSharedData.c(180,25): error: comparison of integers of different signs: 'ZydisInternalElementType' (aka 'enum ZydisInternalElementType_') and 'unsigned long long' [-Werror,-Wsign-compare]
180 | ZYAN_ASSERT(element < ZYAN_ARRAY_LENGTH(lookup));
| ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\webkit\wb\Source\JavaScriptCore\disassembler/zydis/Zydis\ZycoreDefines.h(198,42): note: expanded from macro 'ZYAN_ASSERT'
198 | # define ZYAN_ASSERT(condition) assert(condition)
| ~~~~~~~^~~~~~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\assert.h(40,17): note: expanded from macro 'assert'
40 | (!!(expression)) || \
| ^~~~~~~~~~
1 error generated.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Fujii Hironori
https://github.com/zyantific/zydis/commit/90d54ee8f4f62231bd7dbc0e5f010681b89c5128
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/34682
EWS
Committed 284663@main (9987de5f04ac): <https://commits.webkit.org/284663@main>
Reviewed commits have been landed. Closing PR #34682 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/137263837>