Bug 278824

Summary: [css-line-clamp] Add parsing support for line-clamp shorthand
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, bfulgham, koivisto, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206748    
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2024-08-28 16:16:37 PDT
ssia
Attachments
Patch (10.14 KB, patch)
2024-08-28 16:51 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.12 KB, patch)
2024-08-30 06:53 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (13.83 KB, patch)
2024-08-30 15:05 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2024-08-28 16:23:45 PDT
*** This bug has been marked as a duplicate of bug 278823 ***
alan
Comment 2 2024-08-28 16:51:26 PDT
Reopening to attach new patch.
alan
Comment 3 2024-08-28 16:51:28 PDT
Created attachment 472337 [details] Patch
alan
Comment 4 2024-08-29 20:58:50 PDT
*** Bug 278823 has been marked as a duplicate of this bug. ***
Tim Nguyen (:ntim)
Comment 5 2024-08-29 21:25:32 PDT
Comment on attachment 472337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472337&action=review > Source/WebCore/css/ComputedStyleExtractor.cpp:684 > + Ref<CSSPrimitiveValue> maxLineCount = CSSPrimitiveValue::create(maxLines, CSSUnitType::CSS_INTEGER); Ref maxLineCount =
alan
Comment 6 2024-08-30 06:53:33 PDT
Created attachment 472367 [details] Patch
alan
Comment 7 2024-08-30 15:05:56 PDT
Created attachment 472378 [details] [fast-cq]Patch
EWS
Comment 8 2024-08-30 17:28:15 PDT
Committed 283003@main (e49096b58a79): <https://commits.webkit.org/283003@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472378 [details].
Radar WebKit Bug Importer
Comment 9 2024-08-30 17:29:14 PDT
<rdar://problem/135050023>
Note You need to log in before you can comment on or make changes to this bug.