Bug 275811
Summary: | [Win] Use SystemV ABI for Wasm LLInt on Windows | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ian Grunert <ian.grunert> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | fujii.hironori, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | PC | ||
OS: | Windows 10 |
Ian Grunert
clang-cl gives us the option of changing a function to use the SystemV ABI:
https://clang.llvm.org/docs/AttributeReference.html#sysv-abi
By using this on functions on the C++ / JIT boundaries, we can use the same codepaths for function calls and the same register mappings between Windows and Linux / Mac / BSD.
JS LLInt was completed in bug 274064 and Baseline JIT in bug 275213 so there's no blockers for this.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ian Grunert
Pull request: https://github.com/WebKit/WebKit/pull/30116
EWS
Committed 280334@main (e65584915c8f): <https://commits.webkit.org/280334@main>
Reviewed commits have been landed. Closing PR #30116 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/130505394>