Bug 249415
| Summary: | PR branch names should use the issue number as the canonical reference, not the title string | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, jbedard, ryanhaddad, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Simon Fraser (smfr)
`git webkit pr --issue 249413` when you're already on the PR branch for issue 249413 should not throw an error like it does today:
OpenSource % git webkit pr --issue 249413
Creating a pull-request for '249413' but we're on 'eng/webkitparser-py-should-give-a-better-error-message-when-message-arguments-are-unnamed'
We should fix this by putting the issue number at the start of the branch name, so that the scripts can always associate a branch with an issue. This also makes the branch name immune to retitling the issue.
I suggest:
eng/249413-Foo-bar-baz for bugzilla issues
eng/rdar10249413-Foo-bar-baz for radar issues
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
It's also perfectly reasonable to have multiple issues with the same name ("Gardening iOS tests"), which is also not possible with the current branch naming strategy
Radar WebKit Bug Importer
<rdar://problem/103643814>