Bug 247168
| Summary: | XPCServiceInitializer should process "disable-jit" before "enable-captive-portal-mode". | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | WebKit2 | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
The reason is because "disable-jit" calls JSC::ExecutableAllocator::setJITEnabled(), which should be done before calling JSC::Options::initialize(). The processing of "enable-captive-portal-mode" in XPCServiceInitializer does itself call JSC::ExecutableAllocator::setJITEnabled() before calling JSC::Options::initialize(). Hence, if we process "disable-jit" case afterwards, it will have no effect because JSC::Options::initialize() has already been called.
In practice, this doesn't matter because both the "disable-jit" and "enable-captive-portal-mode" cases disables the JIT. However, just so the code doesn't erroneously suggest that it's ok to call JSC::ExecutableAllocator::setJITEnabled() after calling JSC::Options::initialize(), let's fix the order.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101664549>
Mark Lam
Correction: this is not needed. JSC::ExecutableAllocator::setJITEnabled() needs to be called before JSC::initialized() is called, not before JSC::Options::initialize() is called. So, there's no issue here.