Bug 246881

Summary: [css-typed-om] Use `std::optional<CSSNumberish>&&` instead of `std::optional<CSSNumberish>`
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175733    

Antoine Quint
Reported 2022-10-21 13:16:46 PDT
I got such review feedback during https://github.com/WebKit/WebKit/pull/5641 and it turns out CSSScale::create() had the same problem.
Attachments
Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2022-10-21 13:18:44 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5644
EWS
Comment 2 2022-10-21 22:26:10 PDT
Committed 255864@main (24da58ad6fed): <https://commits.webkit.org/255864@main> Reviewed commits have been landed. Closing PR #5644 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-10-21 22:27:18 PDT
<rdar://problem/101453650>
Note You need to log in before you can comment on or make changes to this bug.