Bug 245677
| Summary: | Reviewers who approve a PR after `validate-commiter-and-reviewer` should be included in the final Reviewed by line | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Wenson Hsieh
In the GitHub workflow, if you have a patch that's
- Reviewed by A
- Tagged with `merge-queue`
- Passes the `validate-commiter-and-reviewer` check in merge queue.
- Reviewed by B
- Lands
...the "Reviewed by" line will only say "Reviewed by A", but it would be ideal to have "Reviewed by A and B".
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/100719648>
Jonathan Bedard
I guess this would entail running the `validate-committer-and-reviewer` check right before landing.