Bug 245268
Summary: | Unreviewed, build fix after 254207@main | ||
---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> |
Component: | New Bugs | Assignee: | Diego Pino <dpino> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | djg, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Diego Pino
Compilation of WebKitGTK/WPE in ARM64 is failing with the following build error:
```
FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp.o
<CXX> -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DGETTEXT_PACKAGE=\"WebKitGTK-4.0\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_PAL -ISource/ThirdParty/libwebrtc -I../../../Source/WebCore/platform/graphics/libwpe -I. -IWebCore/DerivedSources -I../../..
../../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:61:60: error: reference to non-static member function must be called; did you mean to call it with no arguments?
::glReadPixels(x, y, width, height, format, type, data.data);
~~~~~^~~~
()
../../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:217:34: error: reference to non-static member function must be called; did you mean to call it with no arguments?
::glGetIntegerv(pname, value.data);
~~~~~~^~~~
()
../../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:228:67: error: reference to non-static member function must be called; did you mean to call it with no arguments?
::glGetShaderPrecisionFormat(shaderType, precisionType, range.data, precision);
~~~~~~^~~~
()
../../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:233:36: error: reference to non-static member function must be called; did you mean to call it with no arguments?
if (width && height && !pixels.data) {
~~~~~~~^~~~
()
../../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:238:97: error: reference to non-static member function must be called; did you mean to call it with no arguments?
texImage2DDirect(target, level, internalformat, width, height, border, format, type, pixels.data);
~~~~~~~^~~~
()
5 errors generated.
```
This build error was likely introduced in 254207@main, which turned `GCGLSpan::data` attribute into member function `GCGLSpan::data()`.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/4413
EWS
Committed 254551@main (53e44f64a50c): <https://commits.webkit.org/254551@main>
Reviewed commits have been landed. Closing PR #4413 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/100021137>