Bug 241115

Summary: Commit message not showing up in patch review for some patches
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: fujii.hironori, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 239082    
Attachments:
Description Flags
WIP patch none

Alexey Proskuryakov
Reported 2022-05-30 18:52:06 PDT
Commit message is not visible in https://bugs.webkit.org/attachment.cgi?id=459876&action=review, although it's present and looks normal in the raw patch, https://bug-241114-attachments.webkit.org/attachment.cgi?id=459876
Attachments
WIP patch (1.36 KB, patch)
2022-05-30 21:26 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-05-30 21:26:21 PDT
Created attachment 459877 [details] WIP patch
Fujii Hironori
Comment 2 2022-05-30 21:28:50 PDT
I'm not able to find out a good way to decode MIME header with Ruby standard library. Subject: =?UTF-8?q?webkit-patch:=20`git=20am`=20strips=20prefixes=20(e.g.?= =?UTF-8?q?=20[CMake][WPE])=20in=20a=20subject=0Ahttps://bugs.webkit.org/s?= =?UTF-8?q?how=5Fbug.cgi=3Fid=3D241114?=
Fujii Hironori
Comment 3 2022-05-30 21:35:42 PDT
`git mailinfo` command can decode the subject. But I don't know git command is available on the Bugzilla server.
Alexey Proskuryakov
Comment 4 2022-05-30 23:11:34 PDT
Running external commands with untrusted content on the server would be icky. I don't know how all this works though, maybe we already do?
Radar WebKit Bug Importer
Comment 5 2022-06-06 18:53:12 PDT
<rdar://problem/94480379>
Fujii Hironori
Comment 6 2022-06-06 19:14:42 PDT
Bug 241114 was fixed by using --keep-non-patch option rather than --keep option. We don't need to fix this problem. Closed.
Note You need to log in before you can comment on or make changes to this bug.