Bug 240874
| Summary: | Incorrect text set on PR description with multiple commits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, jbedard, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Jean-Yves Avenard [:jya]
I pushed a PR with 3 commits for review:
They are titled
https://github.com/WebKit/WebKit/pull/968
P1. Rework SharedBufferCopy so that we can keep a reference to the underlying SharedMemory
P2. Remove SharedBufferCopy::safeBuffer() and rename SharedBufferCopy::buffer with SharedBufferCopy::unsafeBuffer.
P3. Rename SharedBufferCopy to SharedBufferReference
When pushed, the title of the PR becomes:
"P."
To add: Ideally it would be great if there was a "-m DESCRIPTION, --description=DESCRIPTION" like there was with webkit-patch
as the description can't always be the same as the patch on top of the stack.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93833985>
Alexey Proskuryakov
*** Bug 240873 has been marked as a duplicate of this bug. ***
Jonathan Bedard
This isn't really about the `P1/P2/P3`, it's just a problem about how we determine commit title when there are multiple commits. We're attempting to find the "common string" that all commits share in common.
Jonathan Bedard
*** Bug 244116 has been marked as a duplicate of this bug. ***