Bug 240870

Summary: land-unsafe didn't update the commit log to add the reviewer
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 239082    

Claudio Saavedra
Reported 2022-05-24 06:41:46 PDT
claudio@weichafe:~/git/gnome/WebKit$ Tools/Scripts/webkit-patch land-unsafe --check-oops Logging in as csaavedra@igalia.com... Fetching: https://bugs.webkit.org/show_bug.cgi?id=240869&ctype=xml&excludefield=attachmentdata Guessing "Adrian Perez de Castro" as reviewer from attachment 459721 [details] on bug 240869. svn.webkit.org login: csaavedra@igalia.com svn.webkit.org password for csaavedra@igalia.com: Committed r294743: <https://commits.webkit.org/r294743> Adding comment and closing bug 240869 Closing bug 240869 as fixed https://github.com/WebKit/WebKit/commit/2df4ae08c547cf7d8aceaa178d9da851996a9164
Attachments
Claudio Saavedra
Comment 1 2022-05-24 06:43:00 PDT
Also note that check-oops didn't do what I expected it to do..
Radar WebKit Bug Importer
Comment 2 2022-05-31 06:42:30 PDT
Jonathan Bedard
Comment 3 2022-07-01 14:46:09 PDT
webkit-patch land-unsafe won't work now anyways, everything needs to go through Commit-Queue or Merge-Queue, closing this.
Note You need to log in before you can comment on or make changes to this bug.