Bug 235541

Summary: Web Inspector: Console: move Preserve Log checkbox navigation item to a gear-with-contextmenu to save space (and match the Network Tab)
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235538
Attachments:
Description Flags
[fast-cq] Patch
none
[Image] after Patch is applied
none
[fast-cq] Patch
pangle: review+
[fast-cq] Patch none

Devin Rousso
Reported 2022-01-24 14:19:45 PST
see bug 235538
Attachments
[fast-cq] Patch (16.11 KB, patch)
2022-01-25 12:42 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] after Patch is applied (86.08 KB, image/png)
2022-01-25 12:43 PST, Devin Rousso 		no flags
Details
[fast-cq] Patch (15.13 KB, patch)
2022-01-27 13:38 PST, Devin Rousso 		pangle: review+
DetailsFormatted DiffDiff
[fast-cq] Patch (15.13 KB, patch)
2022-01-27 14:16 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2022-01-25 12:42:21 PST
Created attachment 449955 [details] [fast-cq] Patch
Devin Rousso
Comment 2 2022-01-25 12:43:15 PST
Created attachment 449956 [details] [Image] after Patch is applied
Patrick Angle
Comment 3 2022-01-25 13:39:48 PST
Comment on attachment 449955 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449955&action=review > Source/WebInspectorUI/ChangeLog:33 > + Somehow this got overlooked when the constructor of `WI.ContentBrowser` was changed :( Oops. Pretty sure that is my fault 🤦🏻‍♂️ > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:103 > + this._scopeBar = new WI.ScopeBar("log-scope-bar", scopeBarItems, scopeBarItems[0], shouldGroupNonExclusiveItems); I'm not convinced turning the scope filter items into a dropdown is a good choice here. It is easily possible for multiple items to become selected currently. In fact, if I right click and inspect this page and go to the console tab, I see that by default both "Evaluations" and "Errors" are selected by default. At least for me, seeing "Errors" and "Warnings" at the same time is also common use case.
Devin Rousso
Comment 4 2022-01-26 16:43:20 PST
Comment on attachment 449955 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449955&action=review >> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:103 >> + this._scopeBar = new WI.ScopeBar("log-scope-bar", scopeBarItems, scopeBarItems[0], shouldGroupNonExclusiveItems); > > I'm not convinced turning the scope filter items into a dropdown is a good choice here. It is easily possible for multiple items to become selected currently. In fact, if I right click and inspect this page and go to the console tab, I see that by default both "Evaluations" and "Errors" are selected by default. At least for me, seeing "Errors" and "Warnings" at the same time is also common use case. Oh good point. I totally forgot about this feature 😅 OK I'll pull this part out, but leave the rest of the changes (e.g. move to the left, add `Filter.svg`, etc.). I may also investigate making `WI.MultipleScopeBarItem` actually support multiple items being selected at once (tho that might result in the displayed text just being something like "(multiple)").
Devin Rousso
Comment 5 2022-01-27 13:38:31 PST
Created attachment 450174 [details] [fast-cq] Patch
Patrick Angle
Comment 6 2022-01-27 13:50:21 PST
Comment on attachment 450174 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450174&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + Also collapse the type (and source) scope bar into a single button for more space, and align Nit: Just the source scope bar now.
Devin Rousso
Comment 7 2022-01-27 14:16:41 PST
Created attachment 450176 [details] [fast-cq] Patch
EWS
Comment 8 2022-01-27 14:19:40 PST
Committed r288702 (246500@main): <https://commits.webkit.org/246500@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450176 [details].
Radar WebKit Bug Importer
Comment 9 2022-01-27 16:28:50 PST
<rdar://problem/88159552>
Note You need to log in before you can comment on or make changes to this bug.