Bug 234317

Summary:

[ANGLE] Roll ANGLE to 12-14-2021 (36fcf80b1f2)

Product:

WebKit

Reporter:

Kyle Piddington <kpiddington>

Component:

ANGLE

Assignee:

Kyle Piddington <kpiddington>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, dino, ews-watchlist, gyuyoung.kim, johncunningham, kbr, kkinnunen, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

234356

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch for landing	none

Kyle Piddington

Reported 2021-12-14 14:24:03 PST

Rolling ANGLE forward to include merge-up changes, ContextMTLDevice for memory tracking.

Attachments
Patch (1.72 MB, patch) 2021-12-14 14:30 PST, Kyle Piddington	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (1.63 MB, patch) 2021-12-14 15:18 PST, Kyle Piddington	no flags	Details Formatted Diff Diff
Patch (1.63 MB, patch) 2021-12-14 17:18 PST, Kyle Piddington	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (1.63 MB, patch) 2021-12-14 17:43 PST, Kyle Piddington	no flags	Details Formatted Diff Diff
Patch for landing (1.63 MB, patch) 2021-12-15 01:08 PST, Kyle Piddington	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Kyle Piddington

Comment 1 2021-12-14 14:30:02 PST

Created attachment 447164 [details] Patch

EWS Watchlist

Comment 2 2021-12-14 14:31:18 PST

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

Kenneth Russell

Comment 3 2021-12-14 14:48:45 PST

Comment on attachment 447164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447164&action=review Reviewed all of changes.diff and the Metal backend changes. A few comments, but nothing that should block integration. Let's move forward to unblock John Cunningham's work, and others. r+ > Source/ThirdParty/ANGLE/changes.diff:549 > + Can this whitespace change be removed? It looks like it would eliminate a diff block. > Source/ThirdParty/ANGLE/changes.diff:571 > +- Can this whitespace difference be removed? > Source/ThirdParty/ANGLE/changes.diff:-1081 > -- if (ANGLE_APPLE_AVAILABLE_XI(10.15, 13.0)) We should roll forward to include your https://chromium-review.googlesource.com/c/angle/angle/+/3338624 ASAP - otherwise we'll lose ETC/ASTC support on M1 Macs in Safari, too. > Source/ThirdParty/ANGLE/changes.diff:885 > + def gen_image_map_switch_string(image_table, angle_to_gl): What causes this large diff in the format table generator? Can this be investigated and resolved? > Source/ThirdParty/ANGLE/changes.diff:1171 > +@@ -161,7 +159,7 @@ Additionally - what causes all the diffs in this generated file compared to upstream? > Source/ThirdParty/ANGLE/changes.diff:-3976 > -+ Can this whitespace diff be removed? > Source/ThirdParty/ANGLE/changes.diff:2404 > ++ variable_name, output_file)) Can these formatting changes be reconciled? > Source/ThirdParty/ANGLE/changes.diff:2411 > ++ Can this whitespace change be removed? > Source/ThirdParty/ANGLE/changes.diff:2419 > ++ 'echo "// Compiled binary for Metal default shaders.\n\n" >> \"{0}\"'.format(output_file)) Can this formatting difference be reconciled? > Source/ThirdParty/ANGLE/changes.diff:2423 > ++ Can this whitespace change be reconciled?

Kyle Piddington

Comment 4 2021-12-14 15:18:19 PST

Created attachment 447169 [details] Patch

Kyle Piddington

Comment 5 2021-12-14 17:18:31 PST

Created attachment 447181 [details] Patch

Kyle Piddington

Comment 6 2021-12-14 17:43:16 PST

Created attachment 447184 [details] Patch

Kyle Piddington

Comment 7 2021-12-15 01:08:04 PST

Created attachment 447209 [details] Patch for landing