Bug 234108

Summary: [GPU Process] [Filters] Make FilterEffectVector a Vector of Ref<FilterEffect>
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, heycam, kondapallykalyan, pdr, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231253    
Attachments:
Description Flags
Patch
heycam: review+
Patch none

Said Abou-Hallawa
Reported 2021-12-09 15:39:43 PST
There is no case that would require inserting a nullptr in FilterEffectVector.
Attachments
Patch (21.24 KB, patch)
2021-12-09 23:02 PST, Said Abou-Hallawa 		heycam: review+
DetailsFormatted DiffDiff
Patch (24.72 KB, patch)
2021-12-10 00:56 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2021-12-09 23:02:37 PST
Created attachment 446667 [details] Patch
Cameron McCormack (:heycam)
Comment 2 2021-12-09 23:50:02 PST
Comment on attachment 446667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446667&action=review > Source/WebCore/platform/graphics/filters/FilterEffect.cpp:150 > FilterEffect* FilterEffect::inputEffect(unsigned number) const Should this be changed to return a reference too?
Said Abou-Hallawa
Comment 3 2021-12-10 00:56:11 PST
Created attachment 446677 [details] Patch
EWS
Comment 4 2021-12-10 11:27:54 PST
Committed r286864 (245095@main): <https://commits.webkit.org/245095@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446677 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-10 11:28:31 PST
<rdar://problem/86332124>
Note You need to log in before you can comment on or make changes to this bug.