Bug 233843

Summary: [GPU Process] (REGRESSION r285597): Fix SVGFilter clamping calculation
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, heycam, kondapallykalyan, pdr, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232457
https://bugs.webkit.org/show_bug.cgi?id=231253
https://bugs.webkit.org/show_bug.cgi?id=233849
Bug Depends on:    
Bug Blocks: 231253    
Attachments:
Description Flags
Patch
simon.fraser: review+, ews-feeder: commit-queue-
Patch none

Said Abou-Hallawa
Reported 2021-12-03 16:20:12 PST
Before r285597, there were two transformations for SVGFilter: (1) the transform from the renderer of the SVGFilter to the outer root and (2) the clamping scale. But since we use only the scaling part of the outer root transformation in scaling the SVGFilter, in r285597 the clamping scale and the outer root scale were merged in one FloatSize called filterScale. But I misunderstood the purpose and the arguments of ImageBuffer::sizeNeedsClamping(). And I think also there is a bug in SVGRenderingContext::createImageBuffer(). In this bug the following layout tests should be un-skipped. webkit.org/b/232705 imported/blink/svg/filters/filter-huge-clamping.svg [ Skip ] webkit.org/b/232705 svg/filters/big-sized-off-viewport-filter.svg [ Skip ]
Attachments
Patch (16.84 KB, patch)
2021-12-03 17:33 PST, Said Abou-Hallawa 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (18.59 KB, patch)
2021-12-03 20:42 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2021-12-03 17:33:59 PST
Created attachment 445933 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-12-03 20:04:21 PST
Comment on attachment 445933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445933&action=review > Source/WebCore/rendering/CSSFilter.h:53 > + RefPtr<FilterEffect> lastEffect() const override; or final? > Source/WebCore/svg/graphics/filters/SVGFilter.h:45 > + RefPtr<FilterEffect> lastEffect() const override { return !m_expression.isEmpty() ? m_expression.last() : nullptr; } final
Said Abou-Hallawa
Comment 3 2021-12-03 20:42:00 PST
Created attachment 445951 [details] Patch
EWS
Comment 4 2021-12-03 22:12:33 PST
Committed r286526 (244858@main): <https://commits.webkit.org/244858@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445951 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-03 22:13:21 PST
<rdar://problem/86046194>
Note You need to log in before you can comment on or make changes to this bug.