Bug 233837

Summary: [ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
Product: WebKit Reporter: Dean Jackson <dino>
Component: ANGLEAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kbr, kkinnunen, kondapallykalyan, kpiddington, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220896    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch graouts: review+

Dean Jackson
Reported 2021-12-03 12:49:48 PST
[ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
Attachments
Patch (1.79 KB, patch)
2021-12-03 12:52 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2021-12-15 10:05 PST, Dean Jackson 		graouts: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2021-12-03 12:52:45 PST
Created attachment 445891 [details] Patch
EWS Watchlist
Comment 2 2021-12-03 12:53:44 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2021-12-03 12:56:51 PST
Comment on attachment 445891 [details] Patch Looks fine, though please keep in mind this will collide with the big ANGLE upgrade Kyle's in the middle of in Bug 220896. Unless this is really pressing it might be better to wait for that to complete, but not sure how many blockers there are on that. r+
Dean Jackson
Comment 4 2021-12-03 13:00:15 PST
Agreed. This can wait until Kyle's roll lands, and maybe even come in the next roll if we can fix it upstream.
Kenneth Russell
Comment 5 2021-12-07 14:52:37 PST
Kyle's mega-roll landed in Bug 220896 - would it be feasible to upload this patch to ANGLE's code review tool instead, and pick it up by rolling forward ANGLE again?
Radar WebKit Bug Importer
Comment 6 2021-12-10 12:50:19 PST
<rdar://problem/86335819>
Maciej Stachowiak
Comment 7 2021-12-14 12:27:20 PST
This is breaking a build internally so I'm not sure it can wait?
Kenneth Russell
Comment 8 2021-12-14 17:27:16 PST
Landing this now would be fine if it can't quickly/easily be uploaded to ANGLE's issue tracker. Kyle's landing a follow-on roll right now in Bug 234317 - but it doesn't include this fix.
Dean Jackson
Comment 9 2021-12-15 09:32:43 PST
An update on this. It seems I can't use __has_warning everywhere, so I'll try to add a new CFLAG for -Wno-unknown-warning-option
Dean Jackson
Comment 10 2021-12-15 10:05:30 PST
Created attachment 447250 [details] Patch
Dean Jackson
Comment 11 2021-12-15 10:09:17 PST
Committed r287082 (245277@trunk): <https://commits.webkit.org/245277@trunk>
Note You need to log in before you can comment on or make changes to this bug.