Bug 229960

Summary: Add layout test for performance of adding children to a shadow host
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, gsnedders, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229680    
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2021-09-06 07:05:40 PDT
It was very O(n^2).
Attachments
patch (1.59 KB, patch)
2021-09-06 07:09 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (1.66 KB, patch)
2021-09-06 11:11 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-06 07:09:43 PDT
Created attachment 437411 [details] patch
Antti Koivisto
Comment 2 2021-09-06 11:11:03 PDT
Created attachment 437426 [details] patch
Ryosuke Niwa
Comment 3 2021-09-06 14:11:28 PDT
Comment on attachment 437426 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=437426&action=review > LayoutTests/fast/shadow-dom/host-child-append-performance.html:11 > +for (i = 0; i < 10000; ++i) > + host.appendChild(document.createElement("div")); Wouldn't this test start passing on a very fast machine even if this got broken or start failing on a very slow machine without any regression? I guess there is no way around it.
Antti Koivisto
Comment 4 2021-09-06 23:11:58 PDT
In theory, but this is really far from passing, especially on debug build.
Antti Koivisto
Comment 5 2021-09-06 23:13:14 PDT
(without the fix that is)
EWS
Comment 6 2021-09-06 23:34:42 PDT
Committed r282073 (241373@main): <https://commits.webkit.org/241373@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437426 [details].
Radar WebKit Bug Importer
Comment 7 2021-09-06 23:35:22 PDT
<rdar://problem/82808890>
Note You need to log in before you can comment on or make changes to this bug.