Bug 226877

Summary:

[css-grid] Consider container's writing mode to get grid item's margin

Product:

WebKit

Reporter:

zsun

Component:

CSS

Assignee:

zsun

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, clopez, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, obrufau, pdr, rego, svillar, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.chromium.org/p/chromium/issues/detail?id=1156225

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

zsun

Reported 2021-06-10 06:51:38 PDT

The following WPT tests fail: css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-008.html css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-011.html

Attachments
Patch (11.57 KB, patch) 2021-06-10 07:20 PDT, zsun	no flags	Details Formatted Diff Diff
Patch (11.13 KB, patch) 2021-06-11 01:30 PDT, zsun	no flags	Details Formatted Diff Diff
Patch (10.38 KB, patch) 2021-06-25 03:41 PDT, zsun	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

zsun

Comment 1 2021-06-10 07:20:21 PDT

Created attachment 431076 [details] Patch

EWS Watchlist

Comment 2 2021-06-10 07:21:23 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

zsun

Comment 3 2021-06-11 01:30:01 PDT

Created attachment 431183 [details] Patch

Sergio Villar Senin

Comment 4 2021-06-14 02:38:05 PDT

Comment on attachment 431183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431183&action=review > Source/WebCore/rendering/RenderGrid.cpp:1590 > LayoutUnit gridBorder = isRowAxis ? borderLogicalLeft() : borderBefore(); I wonder whether we have to do the same with borders and/or position. But that's just food for thought for another bug.

Oriol Brufau

Comment 5 2021-06-14 09:49:27 PDT

Comment on attachment 431183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431183&action=review >> Source/WebCore/rendering/RenderGrid.cpp:1590 >> LayoutUnit gridBorder = isRowAxis ? borderLogicalLeft() : borderBefore(); > > I wonder whether we have to do the same with borders and/or position. But that's just food for thought for another bug. Note the border is the one of the grid container. So it already is resolved using the writing mode of the grid container.

Sergio Villar Senin

Comment 6 2021-06-15 00:41:35 PDT

Comment on attachment 431183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431183&action=review >>> Source/WebCore/rendering/RenderGrid.cpp:1590 >>> LayoutUnit gridBorder = isRowAxis ? borderLogicalLeft() : borderBefore(); >> >> I wonder whether we have to do the same with borders and/or position. But that's just food for thought for another bug. > > Note the border is the one of the grid container. So it already is resolved using the writing mode of the grid container. Oh right. But it still stands for the childPosition right?. There are several WPT tests failing in flexbox for example related to vertical-rl due to incorrect offsetLeft and I suspect that might be the cause of issues. Not sure if also here for grid too.

Radar WebKit Bug Importer

Comment 7 2021-06-17 06:52:36 PDT

<rdar://problem/79448742>

zsun

Comment 8 2021-06-24 02:23:22 PDT

The mac-wk2-stress failure looks related to https://bugs.webkit.org/show_bug.cgi?id=225126

zsun

Comment 9 2021-06-25 03:41:55 PDT

Created attachment 432253 [details] Patch

EWS

Comment 10 2021-06-25 06:28:06 PDT

zsun@igalia.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 432253 [details] from commit queue.

EWS

Comment 11 2021-06-25 06:58:32 PDT

Committed r279278 (239157@main): <https://commits.webkit.org/239157@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432253 [details].

Note You need to log in before you can comment on or make changes to this bug.