Bug 224934

Summary: [css-flexbox] Table layout disregards overriding width
Product: WebKit Reporter: Felipe Erias <felipeerias>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221473    
Attachments:
Description Flags
Patch
none
Patch none

Felipe Erias
Reported 2021-04-22 08:45:46 PDT
Several WPT tests fail because table layout does not follow the width that has been set by its flex parent.
Attachments
Patch (12.71 KB, patch)
2021-04-22 09:11 PDT, Felipe Erias 		no flags
DetailsFormatted DiffDiff
Patch (12.51 KB, patch)
2021-04-23 06:21 PDT, Felipe Erias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Felipe Erias
Comment 1 2021-04-22 09:11:54 PDT
Created attachment 426821 [details] Patch
Sergio Villar Senin
Comment 2 2021-04-22 10:03:04 PDT
Comment on attachment 426821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426821&action=review > Source/WebCore/ChangeLog:18 > + Give precedence to the element's overriding width if it has been set, instead of discarding it Super nit: we normally start writing the comment just after the semicolon, so move part of this description to the above line. > Source/WebCore/ChangeLog:20 > + (WebCore::RenderTable::computePreferredLogicalWidths): Ditto. > Source/WebCore/rendering/AutoTableLayout.cpp:287 > + if (tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive()) You can now write this in a single line like this: else if (auto tableLogicalWidth = m_table->style().logicalWidth(); tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive())
Sergio Villar Senin
Comment 3 2021-04-22 10:11:59 PDT
Comment on attachment 426821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426821&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt:24 > +width expected 0 but got 51 You'd have to modify the GTK's specific expectations for this test, otherwise they'll fail in mac platforms
Felipe Erias
Comment 4 2021-04-23 06:21:27 PDT
Created attachment 426901 [details] Patch
Felipe Erias
Comment 5 2021-04-23 06:22:37 PDT
Thank you very much for your review! I have updated the patch as suggested.
EWS
Comment 6 2021-04-25 14:00:16 PDT
Committed r276572 (237008@main): <https://commits.webkit.org/237008@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426901 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-25 14:01:16 PDT
<rdar://problem/77127138>
Note You need to log in before you can comment on or make changes to this bug.