Bug 223997

Summary: Make FontCache constructable and safe to use off the main thread
Product: WebKit Reporter: Chris Lord <clord>
Component: WebCore Misc.Assignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, darin, mmaxfield, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223995    
Bug Blocks: 202793    
Attachments:
Description Flags
Patch
none
Patch none

Chris Lord
Reported 2021-03-31 06:00:38 PDT
For OffscreenCanvas to have its own FontCache separate from the main FontCache singleton, FontCache needs to be constructable and its methods safe to use off the main thread.
Attachments
Patch (30.06 KB, patch)
2021-03-31 15:38 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (31.47 KB, patch)
2021-04-01 01:40 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2021-03-31 15:38:32 PDT
Created attachment 424834 [details] Patch
Darin Adler
Comment 2 2021-03-31 15:44:47 PDT
Comment on attachment 424834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424834&action=review > Source/WebCore/platform/graphics/FontCache.h:41 > +#include <wtf/RefCounted.h> Should not need this if the header is including WTFString.h or AtomString.h > Source/WebCore/platform/graphics/FontCascadeFonts.cpp:491 > + ASSERT(m_thread.ptr() == &Thread::current()); Not sure this does the right thing with the web thread on iOS. > Source/WebCore/platform/graphics/FontCascadeFonts.h:117 > + Ref<Thread> m_thread { Thread::current() }; Should wrap this in #if ASSERT_ENABLED. > Source/WebCore/platform/graphics/FontCascadeFonts.h:129 > + ASSERT(m_thread.ptr() == &Thread::current()); Not sure this does the right thing with the web thread on iOS.
Chris Lord
Comment 3 2021-04-01 01:40:16 PDT
Created attachment 424880 [details] Patch
EWS
Comment 4 2021-04-01 09:10:50 PDT
Committed r275364: <https://commits.webkit.org/r275364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424880 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-01 09:11:15 PDT
<rdar://problem/76106447>
Note You need to log in before you can comment on or make changes to this bug.