Bug 222788

Summary:	Consider making Settings::Values a top-level class
Product:	WebKit	Reporter:	Chris Lord <clord>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Chris Lord

Reported 2021-03-05 01:42:58 PST

Settings::Values is the generic way to access settings from a ScriptExecutionContext, but as it's a sub-class, it means that even having it as an argument requires including Settings.h. We should consider making it a top-level class so that we can use forward declarations and avoid unnecessary proliferation of the Settings include.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-03-12 01:43:20 PST

<rdar://problem/75354585>

Note You need to log in before you can comment on or make changes to this bug.