Bug 222095

Summary: Avoid heap allocation for EventContexts
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kangil.han, koivisto, mifenton, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
ews-feeder: commit-queue-
WIP2
none
WIP2 + cleanup
none
Patch simon.fraser: review+

Ryosuke Niwa
Reported 2021-02-18 00:59:51 PST
We don't need to a class hierarchy to represent different kinds of EventContext. Merge all the subclasses of EventContext onto itself to avoid heap allocation in EventPath.
Attachments
WIP (21.08 KB, patch)
2021-02-18 01:00 PST, Ryosuke Niwa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP2 (21.53 KB, patch)
2021-02-18 18:58 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
WIP2 + cleanup (27.51 KB, patch)
2021-02-19 17:59 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (33.71 KB, patch)
2021-02-24 21:51 PST, Ryosuke Niwa 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-02-18 01:00:10 PST
Created attachment 420804 [details] WIP
Ryosuke Niwa
Comment 2 2021-02-18 18:58:12 PST
Created attachment 420901 [details] WIP2
Ryosuke Niwa
Comment 3 2021-02-19 17:59:50 PST
Created attachment 421066 [details] WIP2 + cleanup
Radar WebKit Bug Importer
Comment 4 2021-02-22 00:33:39 PST
<rdar://problem/74586915>
Ryosuke Niwa
Comment 5 2021-02-24 21:51:29 PST
Created attachment 421500 [details] Patch
Simon Fraser (smfr)
Comment 6 2021-02-24 22:16:06 PST
Comment on attachment 421500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421500&action=review > Source/WebCore/dom/EventContext.h:62 > + bool isMouseOrFocusEventContext() const { return m_type == Type::MouseOrFocus; } > + bool isTouchEventContext() const { return m_type == Type::Touch; } > + bool isWindowContext() const { return m_type == Type::Window; } Not this patch, but it's weird how the context is sometimes about the type of event, and sometimes about the object it's fired on? > Source/WebCore/dom/EventContext.h:104 > + , m_type(type) Can't this be m_type { type } ?
Ryosuke Niwa
Comment 7 2021-02-25 00:22:48 PST
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 421500 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421500&action=review > > > Source/WebCore/dom/EventContext.h:62 > > + bool isMouseOrFocusEventContext() const { return m_type == Type::MouseOrFocus; } > > + bool isTouchEventContext() const { return m_type == Type::Touch; } > > + bool isWindowContext() const { return m_type == Type::Window; } > > Not this patch, but it's weird how the context is sometimes about the type > of event, and sometimes about the object it's fired on? Yup, we should do that. I was initially going to do that in this patch but I decided against it to keep this patch simple & mechanical. > > Source/WebCore/dom/EventContext.h:104 > > + , m_type(type) > > Can't this be m_type { type } ? Oops, fixed. Not sure what happened there. Thanks for the reviews!
Ryosuke Niwa
Comment 8 2021-02-25 00:31:02 PST
Committed r273477 (234556@main): <https://commits.webkit.org/234556@main>
Note You need to log in before you can comment on or make changes to this bug.