Bug 213048

Summary:

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, darin, david_quesada, ews-watchlist, webkit-bug-importer, youennf, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

213781, 213933

Bug Blocks:

203547

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
patch	none
patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2020-06-10 14:09:28 PDT

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory

Attachments
Patch (37.01 KB, patch) 2020-06-10 14:16 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (37.10 KB, patch) 2020-06-15 10:10 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (37.10 KB, patch) 2020-06-15 10:13 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (36.94 KB, patch) 2020-06-15 13:04 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (35.96 KB, patch) 2020-07-02 20:34 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (35.96 KB, patch) 2020-07-02 20:34 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (37.42 KB, patch) 2020-08-24 12:52 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (37.60 KB, patch) 2020-08-24 13:24 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (37.68 KB, patch) 2020-08-24 13:35 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2020-06-10 14:16:53 PDT

Created attachment 401582 [details] Patch

Darin Adler

Comment 2 2020-06-10 14:56:45 PDT

Comment on attachment 401582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401582&action=review > Source/WTF/wtf/PlatformHave.h:413 > + || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ Should be: || ((PLATFORM(IOS) || PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ As I recently learned from Tim Horton.

Alex Christensen

Comment 3 2020-06-15 10:10:45 PDT

Created attachment 401905 [details] Patch

Alex Christensen

Comment 4 2020-06-15 10:13:26 PDT

Created attachment 401907 [details] Patch

Alex Christensen

Comment 5 2020-06-15 13:04:23 PDT

Created attachment 401926 [details] Patch

youenn fablet

Comment 6 2020-06-19 01:42:34 PDT

Comment on attachment 401926 [details] Patch LGTM overall. Can we add some API tests covering HSTS?

Alex Christensen

Comment 7 2020-06-19 10:53:55 PDT

Unfortunately, manual verification is the best we have right now. I've tried hard in the past, but HSTS apparently only persists data in sandboxed apps, and it does not persist in a timely manner.

EWS

Comment 8 2020-06-29 21:39:55 PDT

Committed r263724: <https://trac.webkit.org/changeset/263724> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401926 [details].

Radar WebKit Bug Importer

Comment 9 2020-06-29 21:40:14 PDT

<rdar://problem/64922940>

Yusuke Suzuki

Comment 10 2020-06-30 02:24:21 PDT

Re-opened since this is blocked by bug 213781

David Quesada

Comment 11 2020-06-30 10:07:44 PDT

Comment on attachment 401926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401926&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:301 > + [NSException raise:NSInvalidArgumentException format:@"Cannot set mediaKeysStorageDirectory on a non-persistent _WKWebsiteDataStoreConfiguration."]; This should say `Cannot set hstsStorageDirectory...`

Alex Christensen

Comment 12 2020-07-02 20:34:10 PDT

Created attachment 403435 [details] patch

Alex Christensen

Comment 13 2020-07-02 20:34:55 PDT

Created attachment 403436 [details] patch

EWS

Comment 14 2020-07-02 21:17:59 PDT

Committed r263882: <https://trac.webkit.org/changeset/263882> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403436 [details].

Yusuke Suzuki

Comment 15 2020-07-03 12:57:58 PDT

Re-opened since this is blocked by bug 213933