Bug 210433

Summary: REGRESSION: [ Mac wk2 ] ASSERTION FAILED: m_activeGestureType == ViewGestureType::Swipe in WebKit::ViewGestureController::handleSwipeGesture
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ddkilzer, simon.fraser, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.14   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210283
Attachments:
Description Flags
basic-cached-back-swipe-crash-log none

Jason Lawrence
Reported 2020-04-13 09:46:14 PDT
Created attachment 396297 [details] basic-cached-back-swipe-crash-log swipe/basic-cached-back-swipe.html Description: This test is flaky crashing and timing out on Mac wk2. The flaky crashes appear in the visual history on 04/09/2020. History: https://results.webkit.org/?suite=layout-tests&test=swipe%2Fbasic-cached-back-swipe.html&flavor=wk2&platform=mac&limit=50000 Crash log attached; Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000107c71f5e WTFCrash + 14 (Assertions.cpp:309) 1 com.apple.WebKit 0x0000000117a446cb WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebKit 0x0000000118b569bd WebKit::ViewGestureController::handleSwipeGesture(WebKit::WebBackForwardListItem*, double, WebKit::ViewGestureController::SwipeDirection) + 125 (ViewGestureControllerMac.mm:552) 3 com.apple.WebKit 0x0000000118b540b4 invocation function for block in WebKit::ViewGestureController::trackSwipeGesture(NSEvent*, WebKit::ViewGestureController::SwipeDirection, WTF::RefPtr<WebKit::WebBackForwardListItem, WTF::DumbPtrTraits<WebKit::WebBackForwardListItem> >) + 244 (ViewGestureControllerMac.mm:314) 4 com.apple.AppKit 0x00007fff32027276 ___trackSwipeWithScrollEvent_block_invoke + 2431 5 com.apple.AppKit 0x00007fff31dba5e2 _NSSendEventToObservers + 323 6 com.apple.AppKit 0x00007fff31db90a6 -[NSApplication(NSEvent) sendEvent:] + 82 7 WebKitTestRunner 0x000000010792b62e -[EventStreamPlayer playbackTimerFired:] + 1710 (EventSerializerMac.mm:305) 8 com.apple.Foundation 0x00007fff3708a3ca __NSFireTimer + 67 9 com.apple.CoreFoundation 0x00007fff349b39b9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 10 com.apple.CoreFoundation 0x00007fff349b351f __CFRunLoopDoTimer + 859 11 com.apple.CoreFoundation 0x00007fff349b3007 __CFRunLoopDoTimers + 322 12 com.apple.CoreFoundation 0x00007fff34997daa __CFRunLoopRun + 1871 13 com.apple.CoreFoundation 0x00007fff34996ffe CFRunLoopRunSpecific + 462 14 com.apple.Foundation 0x00007fff3702b2a8 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212 15 WebKitTestRunner 0x000000010797ec9e WTR::TestController::platformRunUntil(bool&, WTF::Seconds) + 302 (TestControllerCocoa.mm:212) 16 WebKitTestRunner 0x000000010793c22f WTR::TestController::runUntil(bool&, WTF::Seconds) + 79 (TestController.cpp:1850) 17 WebKitTestRunner 0x0000000107984762 WTR::TestInvocation::invoke() + 450 (TestInvocation.cpp:185) 18 WebKitTestRunner 0x0000000107945f26 WTR::TestController::runTest(char const*) + 534 (TestController.cpp:1779) 19 WebKitTestRunner 0x00000001079469c6 WTR::TestController::runTestingServerLoop() + 214 (TestController.cpp:1825) 20 WebKitTestRunner 0x000000010793cc07 WTR::TestController::run() + 39 (TestController.cpp:1833) 21 WebKitTestRunner 0x000000010793c57d WTR::TestController::TestController(int, char const**) + 813 (TestController.cpp:168) 22 WebKitTestRunner 0x000000010793ccd3 WTR::TestController::TestController(int, char const**) + 35 (TestController.cpp:169) 23 WebKitTestRunner 0x0000000107910b9c main + 108 (main.mm:70) 24 libdyld.dylib 0x00007fff6e8e0cc9 start + 1
Attachments
basic-cached-back-swipe-crash-log (91.72 KB, text/plain)
2020-04-13 09:46 PDT, Jason Lawrence 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Jason Lawrence
Comment 1 2020-04-13 09:48:30 PDT
This issue is being tracked here: rdar://problem/61645123
Jason Lawrence
Comment 2 2020-04-13 10:16:14 PDT
I have marked this test as crashing and timing out while this issue is investigated. https://trac.webkit.org/changeset/260022/webkit
Ryan Haddad
Comment 3 2020-04-13 10:19:03 PDT
ASSERTION FAILED: m_activeGestureType == ViewGestureType::Swipe /Volumes/Data/slave/catalina-debug/build/Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm(552) : void WebKit::ViewGestureController::handleSwipeGesture(WebKit::WebBackForwardListItem *, double, WebKit::ViewGestureController::SwipeDirection)
Ryan Haddad
Comment 4 2020-04-13 10:21:48 PDT
Probably related to https://trac.webkit.org/changeset/259818/webkit
David Kilzer (:ddkilzer)
Comment 5 2020-04-13 11:14:51 PDT
This is: <rdar://problem/61645123>
David Kilzer (:ddkilzer)
Comment 6 2020-04-13 11:16:46 PDT
(In reply to Jason Lawrence from comment #1) > This issue is being tracked here: rdar://problem/61645123 Oops, didn't see this!
Tim Horton
Comment 7 2025-03-08 02:46:51 PST
Going to give all of the swipe tests new life in bug 282126. *** This bug has been marked as a duplicate of bug 282126 ***
Note You need to log in before you can comment on or make changes to this bug.