Bug 208771

Summary: [CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CMakeAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181117
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2020-03-07 13:58:33 PST
[CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj CMake Visual Studio generator put a custom command of GenerateSettings.rb into both WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj because both projects are using the generated files as source files. This causes unnecessary recompilation. The fundamental issue of this bug was fixed in CMake side. https://gitlab.kitware.com/cmake/cmake/issues/16767 However, WebCoreTestSupportBindings needs to have a direct or indirect dependency to WebCoreBindings for CMake Visual Studio generator to eliminate duplicated custom commands. Otherwise, GenerateSettings.rb will be triggered in both projects. See also: Bug 198853 – [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects Bug 181117 – [CMake][Win] Visual Studio invokes make_names.pl twice
Attachments
Patch (3.13 KB, patch)
2020-03-07 14:04 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-03-07 14:04:28 PST
Created attachment 392897 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-07 15:20:56 PST
Comment on attachment 392897 [details] Patch Clearing flags on attachment: 392897 Committed r258083: <https://trac.webkit.org/changeset/258083>
WebKit Commit Bot
Comment 3 2020-03-07 15:20:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.