Bug 207683

Summary: Replace the usages of (IPC::Attachment fencePort) with IPC::MachPort
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: WebKit Misc.Assignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 13   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Peng Liu
Reported 2020-02-12 23:08:51 PST
Some IPC messages use IPC::Attachment to carry fence ports, we need to use the class MachPort instead.
Attachments
Patch (11.04 KB, patch)
2020-09-21 13:13 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2020-09-21 13:13:05 PDT
Created attachment 409310 [details] Patch
Daniel Bates
Comment 2 2020-09-21 13:44:24 PDT
Comment on attachment 409310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409310&action=review This patch looks good. > Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:795 > + if (DrawingAreaProxy* drawingArea = m_page->drawingArea()) OK as-is. auto* could be used here too. > Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:799 > + m_page->send(Messages::VideoFullscreenManager::SetVideoLayerFrameFenced(contextId, frame, fenceSendRight)); OK as-is. > Source/WebKit/WebProcess/WebPage/WebPage.cpp:3176 > +void WebPage::setTopContentInsetFenced(float contentInset, const WTF::MachSendRight& machSendRight) OK as-is. Could be improved a tiny bit by taking by rvalue reference then need to patch up other places in this patch though. The param name sounds a bit ambiguous too and same comment for same param in WebProcess code. > Source/WebKit/WebProcess/WebPage/WebPage.cpp:3178 > + m_drawingArea->addFence(machSendRight); OK as-is. If ^^^ taken then could patch up addFence to take by rvalue reference and move into.
EWS
Comment 3 2020-09-25 15:09:34 PDT
Committed r267599: <https://trac.webkit.org/changeset/267599> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409310 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-25 15:10:20 PDT
<rdar://problem/69596514>
Note You need to log in before you can comment on or make changes to this bug.