Bug 206736

Summary: Fix various non-unified build issues introduced since r254751
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, clopez, commit-queue, darin, ews-watchlist, keith_miller, mark.lam, msaboff, pnormand, rmorisset, saam, thorton, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206737
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2020-01-24 04:30:27 PST
SSIA. Also, I have a crappy half-working patch which would allow to do “build-webkit --<port> --check --disable-unified-builds” by running the compiler with “-fsyntax-only” — but that will go to a very WIP separate bug :]
Attachments
Patch (7.66 KB, patch)
2020-01-24 04:42 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-01-24 04:42:03 PST
Created attachment 388674 [details] Patch
WebKit Commit Bot
Comment 2 2020-01-24 07:14:31 PST
Comment on attachment 388674 [details] Patch Clearing flags on attachment: 388674 Committed r255070: <https://trac.webkit.org/changeset/255070>
WebKit Commit Bot
Comment 3 2020-01-24 07:14:33 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-01-24 07:15:12 PST
<rdar://problem/58867012>
Darin Adler
Comment 5 2020-01-25 10:02:18 PST
Comment on attachment 388674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388674&action=review > Source/WebCore/Modules/cache/DOMCacheEngine.h:52 > +static inline Exception errorToException(Error error) This doesn’t need to be inlined. We should make this a normal function declaration, stop using "static" and "inline" and move the function definition back into a .cpp file.
Darin Adler
Comment 6 2020-01-26 21:14:25 PST
Comment on attachment 388674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388674&action=review >> Source/WebCore/Modules/cache/DOMCacheEngine.h:52 >> +static inline Exception errorToException(Error error) > > This doesn’t need to be inlined. We should make this a normal function declaration, stop using "static" and "inline" and move the function definition back into a .cpp file. Tackled this in bug 206815.
Adrian Perez
Comment 7 2020-02-06 07:54:11 PST
(In reply to Darin Adler from comment #6) > Comment on attachment 388674 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388674&action=review > > >> Source/WebCore/Modules/cache/DOMCacheEngine.h:52 > >> +static inline Exception errorToException(Error error) > > > > This doesn’t need to be inlined. We should make this a normal function declaration, stop using "static" and "inline" and move the function definition back into a .cpp file. > > Tackled this in bug 206815. Thanks, Darin!
Note You need to log in before you can comment on or make changes to this bug.