Bug 206175

Summary:

Add support for MediaStream audio track rendering in GPUProcess

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, ryanhaddad, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Fixing non MediaStream builds	none
Fixing non MediaStream builds	none
Patch for landing	none

youenn fablet

Reported 2020-01-13 08:12:18 PST

Add support for MediaStream audio track rendering in GPUProcess

Attachments
Patch (50.17 KB, patch) 2020-01-13 08:13 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (59.81 KB, patch) 2020-01-14 00:44 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (59.81 KB, patch) 2020-01-14 00:49 PST, youenn fablet	no flags	Details Formatted Diff Diff
Fixing non MediaStream builds (59.55 KB, patch) 2020-01-15 01:08 PST, youenn fablet	no flags	Details Formatted Diff Diff
Fixing non MediaStream builds (59.55 KB, patch) 2020-01-15 02:13 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (54.47 KB, patch) 2020-01-15 03:55 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2020-01-13 08:13:20 PST

Created attachment 387530 [details] Patch

youenn fablet

Comment 2 2020-01-14 00:44:48 PST

Created attachment 387628 [details] Patch

youenn fablet

Comment 3 2020-01-14 00:49:20 PST

Created attachment 387629 [details] Patch

WebKit Commit Bot

Comment 4 2020-01-14 06:37:56 PST

Comment on attachment 387629 [details] Patch Clearing flags on attachment: 387629 Committed r254505: <https://trac.webkit.org/changeset/254505>

WebKit Commit Bot

Comment 5 2020-01-14 06:37:57 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2020-01-14 06:38:13 PST

<rdar://problem/58566481>

Eric Carlson

Comment 7 2020-01-14 07:50:52 PST

Comment on attachment 387629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387629&action=review > Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:39 > +namespace IPC { > +class Connection; > +class DataReference; > +class Decoder; > +} These probably aren't necessary since you include MessageReceiver.h above.

youenn fablet

Comment 8 2020-01-14 08:04:32 PST

(In reply to Eric Carlson from comment #7) > Comment on attachment 387629 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387629&action=review > > > Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:39 > > +namespace IPC { > > +class Connection; > > +class DataReference; > > +class Decoder; > > +} > > These probably aren't necessary since you include MessageReceiver.h above. Filed https://bugs.webkit.org/show_bug.cgi?id=206236

Ryan Haddad

Comment 9 2020-01-14 09:48:56 PST

Reverted r254505 for reason: Breaks watchOS/tvOS/Catalyst builds. Committed r254516: <https://trac.webkit.org/changeset/254516>

youenn fablet

Comment 10 2020-01-15 00:28:40 PST

*** Bug 206236 has been marked as a duplicate of this bug. ***

youenn fablet

Comment 11 2020-01-15 01:08:52 PST

Created attachment 387760 [details] Fixing non MediaStream builds

WebKit Commit Bot

Comment 12 2020-01-15 02:09:05 PST

Comment on attachment 387760 [details] Fixing non MediaStream builds Rejecting attachment 387760 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 387760, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13304664

youenn fablet

Comment 13 2020-01-15 02:13:49 PST

Created attachment 387767 [details] Fixing non MediaStream builds

WebKit Commit Bot

Comment 14 2020-01-15 03:12:21 PST

The commit-queue encountered the following flaky tests while processing attachment 387767 [details]: media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: simon.pena@samsung.com and vcarbune@chromium.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 15 2020-01-15 03:12:30 PST

The commit-queue encountered the following flaky tests while processing attachment 387767 [details]: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 16 2020-01-15 03:30:57 PST

Comment on attachment 387767 [details] Fixing non MediaStream builds Clearing flags on attachment: 387767 Committed r254562: <https://trac.webkit.org/changeset/254562>

WebKit Commit Bot

Comment 17 2020-01-15 03:30:58 PST

All reviewed patches have been landed. Closing bug.

youenn fablet

Comment 18 2020-01-15 03:55:05 PST

Reopening to attach new patch.

youenn fablet

Comment 19 2020-01-15 03:55:08 PST

Created attachment 387774 [details] Patch for landing

Note You need to log in before you can comment on or make changes to this bug.