Bug 205940

Summary: Fix testing Makefile to inherit preprocessor definitions
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2020-01-08 11:24:50 PST
Fix testing Makefile to inherit preprocessor definitions
Attachments
Patch (1.87 KB, patch)
2020-01-08 11:34 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.65 KB, patch)
2020-01-08 11:46 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.39 KB, patch)
2020-01-08 12:08 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-01-08 11:34:07 PST
Created attachment 387117 [details] Patch
Keith Miller
Comment 2 2020-01-08 11:46:30 PST
Created attachment 387119 [details] Patch
Mark Lam
Comment 3 2020-01-08 12:07:20 PST
Comment on attachment 387119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387119&action=review r=me with fix. > ChangeLog:17 > +2020-01-08 Keith Miller <keith_miller@apple.com> > + > + Fix testing Makefile to inherit preprocessor definitions > + https://bugs.webkit.org/show_bug.cgi?id=205940 > + > + Reviewed by NOBODY (OOPS!). > + > + * Makefile.shared: Remove dupe ChangeLog.
Keith Miller
Comment 4 2020-01-08 12:08:05 PST
Created attachment 387126 [details] Patch for landing
WebKit Commit Bot
Comment 5 2020-01-08 13:17:59 PST
The commit-queue encountered the following flaky tests while processing attachment 387126 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-08 13:18:50 PST
Comment on attachment 387126 [details] Patch for landing Clearing flags on attachment: 387126 Committed r254219: <https://trac.webkit.org/changeset/254219>
WebKit Commit Bot
Comment 7 2020-01-08 13:18:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-01-08 13:19:13 PST
<rdar://problem/58419206>
Note You need to log in before you can comment on or make changes to this bug.