Bug 205843

Summary: Need workaround for crash in Intel OpenGL driver related to texture copying feedback loops
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, graouts, jdarpinian, justin_fan, kondapallykalyan, noam, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.14   
Bug Depends on: 205707, 206200    
Bug Blocks: 205483    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2020-01-06 17:26:38 PST
In Issue 205707, flaky crashes in layout tests: webgl/1.0.3/conformance/textures/texture-copying-feedback-loops.html webgl/2.0.0/conformance/textures/misc/texture-copying-feedback-loops.html were observed after the switch to WebKit's ANGLE backend for WebGL. Upon reducing the test case further for the upstream ANGLE bug: https://bugs.chromium.org/p/angleproject/issues/detail?id=4267 it was discovered that it's a more general problem in Intel's macOS OpenGL driver, and that the workaround wasn't really sufficient. This bug tracks the need for a more thorough workaround.
Attachments
Patch (8.64 KB, patch)
2020-01-13 10:17 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-01-13 10:17:28 PST
Created attachment 387541 [details] Patch
EWS Watchlist
Comment 2 2020-01-13 10:18:07 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
WebKit Commit Bot
Comment 3 2020-01-13 15:06:56 PST
Comment on attachment 387541 [details] Patch Rejecting attachment 387541 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 387541, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=387541&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=205843&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 387541 from bug 205843. Fetching: https://bugs.webkit.org/attachment.cgi?id=387541 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/ThirdParty/ANGLE/ChangeLog M Source/ThirdParty/ANGLE/include/platform/FeaturesGL.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/StateManagerGL.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp M Source/WebCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date W: 62293dba1609d9c4b11eaae384e2b64491a8a491 and refs/remotes/origin/master differ, using rebase: :040000 040000 9725039836045fb21b1ae975d6de27a29aea4688 7d9fac8039936a3a2145972b42321dd7fff2322f M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/ThirdParty/ANGLE/ChangeLog M Source/ThirdParty/ANGLE/include/platform/FeaturesGL.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/StateManagerGL.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp M Source/WebCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date W: 62293dba1609d9c4b11eaae384e2b64491a8a491 and refs/remotes/origin/master differ, using rebase: :040000 040000 9725039836045fb21b1ae975d6de27a29aea4688 7d9fac8039936a3a2145972b42321dd7fff2322f M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 3c87feb64b3..004dc49159c master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 254452 = 3c87feb64b39bb92c94fd24f85882760a74fbc4c r254453 = 5cbb5091ac1a97ec6658059137c1e235d19e61ed r254454 = 004dc49159ce1ab648160048199ae292234d6839 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13303626
Kenneth Russell
Comment 4 2020-01-13 15:20:56 PST
Comment on attachment 387541 [details] Patch I think that failure to commit is a bug in the commit queue. Have just filed https://bugs.webkit.org/show_bug.cgi?id=206200 . Dean / Justin / anyone, could we please try this again?
WebKit Commit Bot
Comment 5 2020-01-14 11:28:37 PST
Comment on attachment 387541 [details] Patch Clearing flags on attachment: 387541 Committed r254520: <https://trac.webkit.org/changeset/254520>
WebKit Commit Bot
Comment 6 2020-01-14 11:28:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-01-14 11:29:14 PST
<rdar://problem/58574742>
Note You need to log in before you can comment on or make changes to this bug.