Bug 205781

Summary: Remove some #ifdefs related to iOS port of ANGLE
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: ANGLEAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, graouts, jdarpinian, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205618    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2020-01-05 14:26:21 PST
With the port to the iOS Simulator in bug 205618, a couple of #ifdefs that were added to ANGLE for the iOS port should be able to be removed. They've been highlighted in this code review upstreaming the iOS port to the ANGLE repository: https://chromium-review.googlesource.com/1987278 We should try removing them, retest on both iOS hardware and the simulator, and if they're unnecessary, upstream their removal.
Attachments
Patch (2.80 KB, patch)
2020-01-08 17:38 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-01-08 17:38:52 PST
Created attachment 387172 [details] Patch
Kenneth Russell
Comment 2 2020-01-08 17:39:53 PST
Dean: could you please test these changes on iOS hardware? They work in the iOS Simulator. This would help with the upstreaming of the iOS backend. Thanks!
EWS Watchlist
Comment 3 2020-01-08 17:39:59 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
WebKit Commit Bot
Comment 4 2020-01-08 18:45:08 PST
Comment on attachment 387172 [details] Patch Clearing flags on attachment: 387172 Committed r254249: <https://trac.webkit.org/changeset/254249>
WebKit Commit Bot
Comment 5 2020-01-08 18:45:09 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-01-08 18:46:14 PST
<rdar://problem/58430149>
Note You need to log in before you can comment on or make changes to this bug.