Bug 205667

Summary: REGRESSION (r253926): webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html is a flaky failure
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jdarpinian, justin_fan, kbr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205483
Bug Depends on: 208724    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2019-12-31 14:55:02 PST
webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html became a flaky failure after the switch to ANGLE. https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance2%2Fbuffers%2Fget-buffer-sub-data.html @@ -29,11 +29,11 @@ [ 26: PASS ] getError was expected value: INVALID_OPERATION : after evaluating: gl.getBufferSubData(gl.ELEMENT_ARRAY_BUFFER, 0, retArray) [ 27: FAIL ] getError expected: INVALID_VALUE. Was INVALID_OPERATION : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, -1, retArray) [ 28: PASS ] getError was expected value: NO_ERROR : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, 0, retArray) -[ 29: PASS ] areArraysEqual(retArray, [0, 0, 0, 0, 0, 0, 0, 0, 0]) is true +[ 29: FAIL ] areArraysEqual(retArray, [0, 0, 0, 0, 0, 0, 0, 0, 0]) should be true. Was false. [ 30: PASS ] getError was expected value: NO_ERROR : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, 0, retArray) [ 31: PASS ] areArraysEqual(retArray, floatArray) is true [ 32: PASS ] getError was expected value: NO_ERROR : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, 0, retArray) [ 33: PASS ] areArraysEqual(retArray, floatArray) is true [ 34: PASS ] successfullyParsed is true -[ FAIL ] 7 failures reported +[ FAIL ] 8 failures reported
Attachments
Patch (1.56 KB, patch)
2020-05-20 23:08 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-31 14:55:13 PST
<rdar://problem/58257175>
Kenneth Russell
Comment 2 2020-01-03 14:11:48 PST
I'll investigate this locally.
Kenneth Russell
Comment 3 2020-01-03 18:20:16 PST
Can't reproduce with a built (release) WebKit inside Safari. Will try to reproduce inside the layout test runner.
James Darpinian
Comment 4 2020-01-10 17:13:09 PST
Can't reproduce on my MacBook Pro or on a MacBookAir7,2 with Intel HD Graphics 6000 and Catalina 10.15.2. I tried running the test standalone and also with the layout test runner along with other tests.
Justin Fan
Comment 5 2020-01-28 18:52:59 PST
I have access to a Catalina mac mini 8,1 for now, but first pass (1000 repeats) hasn't revealed anything yet.
Kenneth Russell
Comment 6 2020-01-28 23:04:40 PST
(In reply to Justin Fan from comment #5) > I have access to a Catalina mac mini 8,1 for now, but first pass (1000 > repeats) hasn't revealed anything yet. Thanks for trying. Just to confirm, you're testing with the current version of ANGLE in WebKit, and with USE_ANGLE=1? If running this test in isolation doesn't repro, what about running the entire set of WebGL conformance tests within the layout tests?
Justin Fan
Comment 7 2020-01-29 17:48:40 PST
The last thing I did was run 25 iterations of a giant list of tests that last led up to the flaky failure on one of our bots, and yes, this was with USE_ANGLE=1 :(
Kenneth Russell
Comment 8 2020-05-20 17:48:55 PDT
Is there any way to tell whether the [ Pass Failure ] expectation for this test can be safely removed? It's likely that the fix for Bug 208724 addressed this flakiness.
Alexey Proskuryakov
Comment 9 2020-05-20 18:46:20 PDT
Indeed, the last failure was right before that fix. The expectation can be removed.
Kenneth Russell
Comment 11 2020-05-20 23:08:39 PDT
Created attachment 399935 [details] Patch
Kenneth Russell
Comment 12 2020-05-20 23:10:06 PDT
Thanks for confirming. I wasn't sure whether the [ Pass Failure ] expectation would mask failures as passes in the bots' history. (Do they show up as warnings?)
Alexey Proskuryakov
Comment 13 2020-05-21 08:22:37 PDT
Comment on attachment 399935 [details] Patch They show up as actual failures in the history, unless you check "Filter expected results" at the right. Thank you for following through on this!
EWS
Comment 14 2020-05-21 08:26:52 PDT
Committed r261997: <https://trac.webkit.org/changeset/261997> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399935 [details].
Note You need to log in before you can comment on or make changes to this bug.