Bug 205623

Summary: [LFC][IFC] Add LineBreaker::Result::Revert to indicate an earlier line wrap opportunity
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2019-12-28 19:58:31 PST
ssia
Attachments
Patch (9.02 KB, patch)
2019-12-28 20:07 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.92 KB, patch)
2019-12-29 09:29 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-28 19:58:54 PST
<rdar://problem/58228339>
alan
Comment 2 2019-12-28 20:07:29 PST
Created attachment 386480 [details] Patch
Antti Koivisto
Comment 3 2019-12-29 02:31:59 PST
Comment on attachment 386480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386480&action=review > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:140 > - return { Result::Action::Keep, IsEndOfLine::No, { } }; > + return Result { Result::Action::Keep }; Why name the type here and elsewhere? > Source/WebCore/layout/inlineformatting/InlineLineBreaker.h:66 > + Result(Action, IsEndOfLine = IsEndOfLine::No, Optional<PartialTrailingContent> = WTF::nullopt, const InlineItem* revertTo = nullptr); > + > + Action action { Action::Keep }; > + IsEndOfLine isEndOfLine { IsEndOfLine::No }; > Optional<PartialTrailingContent> partialTrailingContent; > + const InlineItem* revertTo { nullptr }; > }; I don't think you need a constructor if you make it Optional<PartialTrailingContent> partialTrailingContent { };
alan
Comment 4 2019-12-29 08:54:03 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 386480 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386480&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:140 > > - return { Result::Action::Keep, IsEndOfLine::No, { } }; > > + return Result { Result::Action::Keep }; > > Why name the type here and elsewhere? Because I did not pay attention? > > > Source/WebCore/layout/inlineformatting/InlineLineBreaker.h:66 > > + Result(Action, IsEndOfLine = IsEndOfLine::No, Optional<PartialTrailingContent> = WTF::nullopt, const InlineItem* revertTo = nullptr); > > + > > + Action action { Action::Keep }; > > + IsEndOfLine isEndOfLine { IsEndOfLine::No }; > > Optional<PartialTrailingContent> partialTrailingContent; > > + const InlineItem* revertTo { nullptr }; > > }; > > I don't think you need a constructor if you make it > > Optional<PartialTrailingContent> partialTrailingContent { }; oh cool
alan
Comment 5 2019-12-29 09:29:20 PST
Created attachment 386492 [details] Patch
WebKit Commit Bot
Comment 6 2019-12-29 10:27:41 PST
The commit-queue encountered the following flaky tests while processing attachment 386492 [details]: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html bug 203433 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2019-12-29 10:28:31 PST
Comment on attachment 386492 [details] Patch Clearing flags on attachment: 386492 Committed r253937: <https://trac.webkit.org/changeset/253937>
WebKit Commit Bot
Comment 8 2019-12-29 10:28:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.