Bug 205543

Summary: Very basic <dialog> show/close support
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, cdumez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, ryuan.choi, sam, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635    
Attachments:
Description Flags
Patch
none
Patch
koivisto: review+
Patch none

Simon Fraser (smfr)
Reported 2019-12-21 12:51:00 PST
Very basic <dialog> show/close support
Attachments
Patch (30.18 KB, patch)
2019-12-21 12:54 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (45.42 KB, patch)
2019-12-21 13:25 PST, Simon Fraser (smfr) 		koivisto: review+
DetailsFormatted DiffDiff
Patch (60.35 KB, patch)
2019-12-22 13:45 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-12-21 12:54:27 PST
Created attachment 386301 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-12-21 13:25:42 PST
Created attachment 386302 [details] Patch
Antti Koivisto
Comment 3 2019-12-22 09:12:24 PST
Comment on attachment 386302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386302&action=review > Source/WebCore/style/UserAgentStyle.cpp:237 > + else if (is<HTMLDialogElement>(element) && RuntimeEnabledFeatures::sharedFeatures().dialogElementEnabled()) { > + if (!dialogStyleSheet) { > + dialogStyleSheet = parseUASheet(dialogUserAgentStyleSheet, sizeof(dialogUserAgentStyleSheet)); > + addToDefaultStyle(*dialogStyleSheet); > + } > + } We should remember to merge this to the main stylesheet when this ships. > Source/WebKit/Shared/WebPreferences.yaml:1889 > + category: internal Don't web facing things usually go to experimental?
Simon Fraser (smfr)
Comment 4 2019-12-22 13:45:50 PST
Created attachment 386320 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-12-22 19:55:45 PST
https://trac.webkit.org/changeset/253880/webkit
Radar WebKit Bug Importer
Comment 6 2019-12-22 19:56:17 PST
<rdar://problem/58151097>
Note You need to log in before you can comment on or make changes to this bug.