Bug 204728

Created attachment 384574 [details] Patch

Should I preserved the tools/wptserve/wptserve/*/w3c-import.log files? If so, we should move them out of the tools directory.

This patch prevents layout-tests from running, with below error. e.g.: https://ews-build.webkit.org/#/builders/17/builds/7579 ServerError raised: WPT Server process exited prematurely with status code None The cmdline for running the WPT server was: ['python', '/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/LayoutTests/imported/w3c/web-platform-tests/wpt.py', 'serve', '--config', '/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/LayoutTests/imported/w3c/web-platform-tests/config.json'] Traceback (most recent call last): File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 91, in main run_details = run(port, options, args, stderr) File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 466, in run run_details = manager.run(args) File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 230, in run needs_http=needs_http, needs_web_platform_test_server=needs_web_platform_test_server, needs_websockets=needs_websockets) File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 88, in __init__ self.start_servers() File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 224, in start_servers self._port.start_web_platform_test_server() File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/port/base.py", line 1036, in start_web_platform_test_server self._web_platform_test_server.start() File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py", line 98, in start self._pid = self._spawn_process() File "/Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py", line 141, in _spawn_process raise http_server_base.ServerError(error_log) ServerError: WPT Server process exited prematurely with status code None

(In reply to Simon Fraser (smfr) from comment #2) > Should I preserved the tools/wptserve/wptserve/*/w3c-import.log files? > > If so, we should move them out of the tools directory. We use the logs to remove WebKit imported files that have been removed from the upstream repo. "Tools/Scripts/import-w3c-tests -t web-platform-tests/tools"should do the trick. This should keep generation of the w3c-import.log files. I tried the patch locally and it works for me. As of the build error, we do not have much info. /Volumes/Data/worker/macOS-High-Sierra-Debug-WK1-Tests-EWS/build/layout-test-results/wptwk_process_log.out.txt should give more information. It might be good to regenerate the patch with Tools/Scripts/import-w3c-tests and if still failing, check the above file for more information.

Created attachment 384712 [details] Patch using importer

New patch seems to run well.

Comment on attachment 384712 [details] Patch using importer r=me but please check the test failures.

Failures are probably due to changes in tools. This might require resyncing service worker and xhr tests. I'll update test expectations to land this patch first.

Created attachment 384806 [details] Patch for landing

Comment on attachment 384806 [details] Patch for landing Clearing flags on attachment: 384806 Committed r253104: <https://trac.webkit.org/changeset/253104>

All reviewed patches have been landed. Closing bug.

<rdar://problem/57623876>