Bug 203916

Summary: Enable GPU switching with ANGLE
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Enable GPU switching with ANGLE
none
Fix build error
none
Rebase on Dean's ANGLE/iOS changes
none
Rebase again none

James Darpinian
Reported 2019-11-06 13:21:11 PST
Enable GPU switching with ANGLE
Attachments
Enable GPU switching with ANGLE (7.89 KB, patch)
2019-11-06 13:24 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Fix build error (8.17 KB, patch)
2019-11-06 14:05 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Rebase on Dean's ANGLE/iOS changes (7.30 KB, patch)
2019-11-15 17:27 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Rebase again (7.40 KB, patch)
2019-11-22 16:13 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-11-06 13:24:08 PST
Created attachment 382953 [details] Enable GPU switching with ANGLE
James Darpinian
Comment 2 2019-11-06 14:05:04 PST
Created attachment 382959 [details] Fix build error
Alex Christensen
Comment 3 2019-11-08 13:44:42 PST
Comment on attachment 382959 [details] Fix build error View in context: https://bugs.webkit.org/attachment.cgi?id=382959&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.h:1195 > +#if USE(OPENGL) || USE(ANGLE) Did you intentionally drop the PLATFORM(MAC)? Does this work on iOS, too? Also EWS says this needs rebasing. Does it?
James Darpinian
Comment 4 2019-11-15 17:27:50 PST
Created attachment 383676 [details] Rebase on Dean's ANGLE/iOS changes
James Darpinian
Comment 5 2019-11-15 17:30:48 PST
Comment on attachment 382959 [details] Fix build error View in context: https://bugs.webkit.org/attachment.cgi?id=382959&action=review >> Source/WebCore/platform/graphics/GraphicsContext3D.h:1195 >> +#if USE(OPENGL) || USE(ANGLE) > > Did you intentionally drop the PLATFORM(MAC)? Does this work on iOS, too? > Also EWS says this needs rebasing. Does it? It didn't work on iOS before, but this was before Dean landed his patches for ANGLE iOS support. I've rebased this and it should work now.
James Darpinian
Comment 6 2019-11-22 16:13:43 PST
Created attachment 384213 [details] Rebase again
WebKit Commit Bot
Comment 7 2019-11-27 10:59:46 PST
Comment on attachment 384213 [details] Rebase again Clearing flags on attachment: 384213 Committed r252909: <https://trac.webkit.org/changeset/252909>
WebKit Commit Bot
Comment 8 2019-11-27 10:59:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-11-27 11:00:21 PST
<rdar://problem/57508688>
Note You need to log in before you can comment on or make changes to this bug.