Bug 203743

Summary:

Web Inspector: default to focusing the console prompt if no other content is focused after opening Web Inspector

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, eric.carlson, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

203744, 203932, 203939

Attachments:

Description	Flags
Patch	eric.carlson: review+
Patch	hi: commit-queue+
Archive of layout-test-results from webkit-cq-01 for mac-highsierra	none
Patch	none

Devin Rousso

Reported 2019-11-01 09:54:39 PDT

If the user is looking at the Canvas Tab, for example, there is no preserved selection/focused state between Web Inspector sessions, so if the user opens Web Inspector to the Canvas Tab, there will be no initial focus.

Attachments
Patch (2.34 KB, patch) 2019-11-01 10:01 PDT, Devin Rousso	eric.carlson: review+	Details Formatted Diff Diff
Patch (2.34 KB, patch) 2019-11-01 13:50 PDT, Devin Rousso	hi: commit-queue+	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-highsierra (3.70 MB, application/zip) 2019-11-01 15:21 PDT, WebKit Commit Bot	no flags	Details
Patch (2.34 KB, patch) 2019-11-01 16:20 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-11-01 10:01:52 PDT

Created attachment 382590 [details] Patch

Eric Carlson

Comment 2 2019-11-01 11:46:19 PDT

Comment on attachment 382590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382590&action=review Thank you! > Source/WebInspectorUI/UserInterface/Base/Main.js:925 > + return !WI._defaultFocusedQuickConcolePrompt && WI.quickConsole.prompt.focused; Nit: s/_defaultFocusedQuickConcolePrompt/_defaultFocusedQuickConsolePrompt/ > Source/WebInspectorUI/UserInterface/Base/Main.js:1364 > + WI._defaultFocusedQuickConcolePrompt = false; Ditto. > Source/WebInspectorUI/UserInterface/Base/Main.js:1546 > + WI._defaultFocusedQuickConcolePrompt = true; Ditto

Blaze Burg

Comment 3 2019-11-01 11:48:11 PDT

Comment on attachment 382590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382590&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:925 > + return !WI._defaultFocusedQuickConcolePrompt && WI.quickConsole.prompt.focused; Typo: console A better name could be: WI._didAutofocusConsolePrompt

Devin Rousso

Comment 4 2019-11-01 13:50:12 PDT

Created attachment 382619 [details] Patch

WebKit Commit Bot

Comment 5 2019-11-01 15:05:39 PDT Comment hidden (obsolete)

The commit-queue encountered the following flaky tests while processing attachment 382619 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 6 2019-11-01 15:05:45 PDT Comment hidden (obsolete)

The commit-queue encountered the following flaky tests while processing attachment 382619 [details]: imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg bug 203172 (author: sabouhallawa@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 7 2019-11-01 15:21:44 PDT Comment hidden (obsolete)

Comment on attachment 382619 [details] Patch Rejecting attachment 382619 [details] from commit-queue. New failing tests: requestidlecallback/requestidlecallback-document-gc.html Full output: https://webkit-queues.webkit.org/results/13202266

WebKit Commit Bot

Comment 8 2019-11-01 15:21:46 PDT Comment hidden (obsolete)

Created attachment 382638 [details] Archive of layout-test-results from webkit-cq-01 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 9 2019-11-01 16:20:08 PDT

Created attachment 382648 [details] Patch

WebKit Commit Bot

Comment 10 2019-11-01 17:19:21 PDT

Comment on attachment 382648 [details] Patch Clearing flags on attachment: 382648 Committed r251958: <https://trac.webkit.org/changeset/251958>

WebKit Commit Bot

Comment 11 2019-11-01 17:19:22 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2019-11-01 17:20:22 PDT

<rdar://problem/56833461>

Note You need to log in before you can comment on or make changes to this bug.