Bug 203202

Summary: results.webkit.org: Add ability to display time on bubbles
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Screen shot
none
Patch
none
Screen shot (collapsed)
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-10-21 12:48:39 PDT
For tests which are close to timing out, it's useful to have an easy way to visualize the time it took to run a test.
Attachments
Patch (3.82 KB, patch)
2019-10-21 13:01 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Screen shot (519.22 KB, image/png)
2019-10-21 13:53 PDT, Jonathan Bedard 		no flags
Details
Patch (4.28 KB, patch)
2019-10-21 14:29 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Screen shot (collapsed) (198.52 KB, image/png)
2019-10-21 14:31 PDT, Jonathan Bedard 		no flags
Details
Patch (4.29 KB, patch)
2019-10-21 14:46 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.29 KB, patch)
2019-10-21 15:16 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-21 12:49:06 PDT
<rdar://problem/56436621>
Jonathan Bedard
Comment 2 2019-10-21 13:01:05 PDT
Created attachment 381432 [details] Patch
Aakash Jain
Comment 3 2019-10-21 13:19:40 PDT
Can you add a screenshot indicating how it would look like?
Jonathan Bedard
Comment 4 2019-10-21 13:53:10 PDT
Created attachment 381446 [details] Screen shot
Jonathan Bedard
Comment 5 2019-10-21 14:29:56 PDT
Created attachment 381454 [details] Patch
Jonathan Bedard
Comment 6 2019-10-21 14:31:31 PDT
Created attachment 381456 [details] Screen shot (collapsed)
Jonathan Bedard
Comment 7 2019-10-21 14:46:14 PDT
Created attachment 381459 [details] Patch
Aakash Jain
Comment 8 2019-10-21 14:47:55 PDT
Comment on attachment 381459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381459&action=review rs=me > Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:909 > + <label>Show test times</label> Would it be better to label it: "Show test times (in s)"
Alexey Proskuryakov
Comment 9 2019-10-21 15:01:07 PDT
> Would it be better to label it: "Show test times (in s)" That seems unusual and detached from the actual number to me. With the old dashboard, it was clear enough based on the range of values.
Jonathan Bedard
Comment 10 2019-10-21 15:11:17 PDT
(In reply to Alexey Proskuryakov from comment #9) > > Would it be better to label it: "Show test times (in s)" > > That seems unusual and detached from the actual number to me. With the old > dashboard, it was clear enough based on the range of values. The patch up for review now displays seconds, so it's going to be between 1 and 30 (except for special tests that override the default timeout) which I think is the behavior of the old dashboard.
Jonathan Bedard
Comment 11 2019-10-21 15:16:24 PDT
Created attachment 381467 [details] Patch for landing
WebKit Commit Bot
Comment 12 2019-10-21 17:21:24 PDT
The commit-queue encountered the following flaky tests while processing attachment 381467 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 13 2019-10-21 17:22:16 PDT
Comment on attachment 381467 [details] Patch for landing Clearing flags on attachment: 381467 Committed r251401: <https://trac.webkit.org/changeset/251401>
WebKit Commit Bot
Comment 14 2019-10-21 17:22:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.