Bug 203023

Summary: Make requestIdleCallback suspendable
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, koivisto, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164193    
Attachments:
Description Flags
WIP
none
Adds support
none
Fixed tests
none
Updated for trunk
ews-watchlist: commit-queue-
Archive of layout-test-results from ews213 for win-future
none
Fixed the test for ToT cdumez: review+, cdumez: commit-queue-

Ryosuke Niwa
Reported 2019-10-15 20:39:53 PDT
Make it possible to put a document with pending requestIdleCallbacks into page cache.
Attachments
WIP (6.97 KB, patch)
2019-10-15 20:40 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Adds support (10.64 KB, patch)
2019-10-16 01:19 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed tests (10.64 KB, patch)
2019-10-16 20:00 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for trunk (10.61 KB, patch)
2019-10-16 20:13 PDT, Ryosuke Niwa 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (13.90 MB, application/zip)
2019-10-16 21:36 PDT, EWS Watchlist 		no flags
Details
Fixed the test for ToT (10.62 KB, patch)
2019-10-16 21:55 PDT, Ryosuke Niwa 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-10-15 20:40:23 PDT
Created attachment 381050 [details] WIP
Ryosuke Niwa
Comment 2 2019-10-16 01:19:41 PDT
Created attachment 381061 [details] Adds support
Ryosuke Niwa
Comment 3 2019-10-16 20:00:07 PDT
Created attachment 381150 [details] Fixed tests
Ryosuke Niwa
Comment 4 2019-10-16 20:13:17 PDT
Created attachment 381151 [details] Updated for trunk
EWS Watchlist
Comment 5 2019-10-16 21:36:54 PDT
Comment on attachment 381151 [details] Updated for trunk Attachment 381151 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13141881 New failing tests: requestidlecallback/requestidlecallback-in-page-cache.html
EWS Watchlist
Comment 6 2019-10-16 21:36:56 PDT
Created attachment 381156 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Ryosuke Niwa
Comment 7 2019-10-16 21:55:20 PDT
Created attachment 381159 [details] Fixed the test for ToT
Chris Dumez
Comment 8 2019-10-17 08:26:03 PDT
Comment on attachment 381159 [details] Fixed the test for ToT View in context: https://bugs.webkit.org/attachment.cgi?id=381159&action=review r=me > Source/WebCore/dom/WindowEventLoop.cpp:84 > + for (auto& task : m_tasks) remainingTasks.appendVector(m_tasks); would be more concise and likely more efficient. > Source/WebCore/dom/WindowEventLoop.h:69 > + Vector<Task> m_suspendedTasks; This appears to be unused?
Ryosuke Niwa
Comment 9 2019-10-17 10:29:36 PDT
(In reply to Chris Dumez from comment #8) > Comment on attachment 381159 [details] > Fixed the test for ToT > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381159&action=review > > r=me > > > Source/WebCore/dom/WindowEventLoop.cpp:84 > > + for (auto& task : m_tasks) > > remainingTasks.appendVector(m_tasks); would be more concise and likely more > efficient. The problem is that remainingTasks.appendVector doesn't support movable but non-copyable objects. I'm gonna keep it as is but we should probably add a new variant of appendVector which supports move constructor. > > Source/WebCore/dom/WindowEventLoop.h:69 > > + Vector<Task> m_suspendedTasks; > > This appears to be unused? Oh oops, removed.
Ryosuke Niwa
Comment 10 2019-10-17 14:22:32 PDT
Committed r251258: <https://trac.webkit.org/changeset/251258>
Radar WebKit Bug Importer
Comment 11 2019-10-17 14:23:20 PDT
<rdar://problem/56385403>
Note You need to log in before you can comment on or make changes to this bug.