Bug 202572

Summary: Implement OffscreenCanvas.transferToImageBitmap
Product: WebKit Reporter: Chris Lord <clord>
Component: CanvasAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dino, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, hi, koivisto, kondapallykalyan, mattbaker, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer, ysuzuki, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183440    
Bug Blocks: 183720, 202573    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Attachments
Patch (17.50 KB, patch)
2019-10-10 03:45 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (17.11 KB, patch)
2019-12-03 03:51 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (17.41 KB, patch)
2019-12-04 03:08 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2019-10-10 03:45:34 PDT
Created attachment 380627 [details] Patch
Chris Lord
Comment 2 2019-12-03 03:51:41 PST
Created attachment 384704 [details] Patch
Antti Koivisto
Comment 3 2019-12-03 06:36:53 PST
Comment on attachment 384704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384704&action=review > Source/WebCore/html/OffscreenCanvas.cpp:195 > + m_hasCreatedImageBuffer = true; Shouldn't this be set only after the nullptr return path? > Source/WebCore/html/OffscreenCanvas.cpp:197 > + if (!width() || !height()) size().isEmpty()?
Chris Lord
Comment 4 2019-12-04 03:08:23 PST
Created attachment 384801 [details] Patch
WebKit Commit Bot
Comment 5 2019-12-04 03:54:06 PST
Comment on attachment 384801 [details] Patch Clearing flags on attachment: 384801 Committed r253099: <https://trac.webkit.org/changeset/253099>
WebKit Commit Bot
Comment 6 2019-12-04 03:54:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-04 03:55:24 PST
<rdar://problem/57620574>
Darin Adler
Comment 8 2019-12-04 09:17:59 PST
Comment on attachment 384801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384801&action=review > Source/WebCore/html/CanvasBase.h:113 > + std::unique_ptr<ImageBuffer> setImageBuffer(std::unique_ptr<ImageBuffer>&&) const; C++ calls this operation "exchange" as in "std::exchange", rather than "set". I think we might want to name this function accordingly.
Note You need to log in before you can comment on or make changes to this bug.