Bug 202565

Summary: [WebAuthn] Write more tests for _WKWebAuthenticationPanel
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202560    
Bug Blocks: 182769    
Attachments:
Description Flags
Patch
none
Patch none

Jiewen Tan
Reported 2019-10-03 22:52:55 PDT
Write more tests for _WKWebAuthenticationPanel. Potential test set could be: 1) a test without any panel client; 2) a test with _WKWebAuthenticationResultSucceeded; 3) a test with race condition that a new request comes in between; 4) a test with a new request cancels the other.
Attachments
Patch (20.07 KB, patch)
2019-10-10 14:38 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (20.12 KB, patch)
2019-10-11 01:33 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-03 22:53:28 PDT
<rdar://problem/55974128>
Jiewen Tan
Comment 2 2019-10-10 14:38:00 PDT
Created attachment 380686 [details] Patch
Jiewen Tan
Comment 3 2019-10-11 01:33:25 PDT
Created attachment 380733 [details] Patch
Jiewen Tan
Comment 4 2019-10-11 12:05:39 PDT
I don't think the iOS-WK2 failures should blame this patch.
Brent Fulgham
Comment 5 2019-10-15 09:10:26 PDT
(In reply to Jiewen Tan from comment #4) > I don't think the iOS-WK2 failures should blame this patch. Yes. It looks like both of the test failures are flaky crashes, according to the dashboard.
Brent Fulgham
Comment 6 2019-10-15 09:12:47 PDT
Comment on attachment 380733 [details] Patch It's always good to see more tests! r=me (please watch the bots once this lands to make sure we don't introduce any bot issues).
Jiewen Tan
Comment 7 2019-10-15 10:38:24 PDT
Comment on attachment 380733 [details] Patch Thanks Brent for r+ this patch.
WebKit Commit Bot
Comment 8 2019-10-15 11:21:59 PDT
Comment on attachment 380733 [details] Patch Clearing flags on attachment: 380733 Committed r251148: <https://trac.webkit.org/changeset/251148>
WebKit Commit Bot
Comment 9 2019-10-15 11:22:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.