Bug 201207

Summary: [WebGPU] Make WebGPURenderPipeline and WebGPUComputePipeline inherit from GPUObjectBase
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGPUAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Justin Fan
Reported 2019-08-27 16:57:44 PDT
...Instead of having the internal classes inherit from GPUObjectBase.
Attachments
Patch (14.73 KB, patch)
2019-09-13 16:32 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-09-13 16:32:47 PDT
Created attachment 378759 [details] Patch
Dean Jackson
Comment 2 2019-09-13 16:46:13 PDT
Comment on attachment 378759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378759&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:26010 > + D03586B222D7F2EA00DA0284 /* GPUErrorScopes.cpp */, > + D03586B122D7F2EA00DA0284 /* GPUErrorScopes.h */, Aren't you missing these files? And shouldn't they be in Sources.txt too?
Justin Fan
Comment 3 2019-09-13 16:47:35 PDT
Comment on attachment 378759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378759&action=review >> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26010 >> + D03586B122D7F2EA00DA0284 /* GPUErrorScopes.h */, > > Aren't you missing these files? > > And shouldn't they be in Sources.txt too? Hmm... these were already in the project. Maybe something in the build process added extra references?
WebKit Commit Bot
Comment 4 2019-09-14 15:31:08 PDT
Comment on attachment 378759 [details] Patch Clearing flags on attachment: 378759 Committed r249881: <https://trac.webkit.org/changeset/249881>
WebKit Commit Bot
Comment 5 2019-09-14 15:31:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-14 15:32:16 PDT
<rdar://problem/55371078>
Note You need to log in before you can comment on or make changes to this bug.