Bug 200759

Summary: [JSC] Air does not appropriately propagate ConstFloatValue to stackmap
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200362    
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-08-14 22:52:30 PDT
[JSC] Air does not appropriately propagate ConstFloatValue to stackmap
Attachments
Patch (9.60 KB, patch)
2019-08-14 23:01 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.62 KB, patch)
2019-08-14 23:29 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-08-14 23:01:36 PDT
Created attachment 376357 [details] Patch
EWS Watchlist
Comment 2 2019-08-14 23:06:38 PDT
Attachment 376357 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:48: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:80: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2019-08-14 23:29:14 PDT
Created attachment 376361 [details] Patch
EWS Watchlist
Comment 4 2019-08-14 23:35:42 PDT
Attachment 376361 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:48: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:80: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 5 2019-08-14 23:37:17 PDT
Thanks for review!
Yusuke Suzuki
Comment 6 2019-08-14 23:39:33 PDT
Committed r248710: <https://trac.webkit.org/changeset/248710>
Radar WebKit Bug Importer
Comment 7 2019-08-14 23:40:15 PDT
<rdar://problem/54335168>
Note You need to log in before you can comment on or make changes to this bug.