Bug 200733

Summary: Make sure JSC tool targets unlock the keychain before codesigning
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ews-watchlist, keith_miller, krollin, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202123    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Tadeu Zagallo
Reported 2019-08-14 13:46:52 PDT
...
Attachments
Patch (13.17 KB, patch)
2019-08-14 13:51 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.94 KB, patch)
2019-08-19 14:00 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-08-14 13:51:01 PDT
Created attachment 376306 [details] Patch
Alexey Proskuryakov
Comment 2 2019-08-14 16:54:51 PDT
Comment on attachment 376306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376306&action=review > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:1919 > + inputFiles = ( > + ); Looks like an unrelated change.
Tadeu Zagallo
Comment 3 2019-08-19 14:00:14 PDT
Comment on attachment 376306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376306&action=review Thanks for the review! >> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:1919 >> + ); > > Looks like an unrelated change. Oops, Xcode inserted this.
Tadeu Zagallo
Comment 4 2019-08-19 14:00:38 PDT
Created attachment 376708 [details] Patch for landing
Alexey Proskuryakov
Comment 5 2019-08-19 14:02:12 PDT
rdar://problem/54223095
WebKit Commit Bot
Comment 6 2019-08-19 14:34:14 PDT
Comment on attachment 376708 [details] Patch for landing Clearing flags on attachment: 376708 Committed r248866: <https://trac.webkit.org/changeset/248866>
WebKit Commit Bot
Comment 7 2019-08-19 14:34:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.