Bug 198185

Summary: [iOS] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is frequently failing or timing out
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, katherine_cheney, repstein, sroberts, webkit-bot-watchers-bugzilla, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195923
Attachments:
Description Flags
Patch for landing
none
Update TestExpectations
none
Patch
none
Patch none

Ryan Haddad
Reported 2019-05-23 10:56:37 PDT
The following layout test is frequently failing or timing out on iOS http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html Probable cause: Unknown, the regression point cannot be determined with flakiness dashboard data. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fwebsite-data-removal-for-site-navigated-to-with-link-decoration.html --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-actual.txt @@ -10,7 +10,7 @@ After deletion: Client-side cookie exists. After deletion: Regular server-side cookie exists. After deletion: LocalStorage entry does not exist. -After deletion: IDB entry does not exist. +After deletion: IDB entry does exist. Resource load statistics:
Attachments
Patch for landing (7.56 KB, patch)
2019-06-14 18:29 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Update TestExpectations (1.58 KB, patch)
2019-06-18 13:11 PDT, Russell Epstein 		no flags
DetailsFormatted DiffDiff
Patch (3.31 KB, patch)
2019-10-16 17:55 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (2.90 KB, patch)
2019-10-17 09:21 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-23 10:56:57 PDT
<rdar://problem/51074251>
Shawn Roberts
Comment 2 2019-06-11 09:20:10 PDT
Test is timing out or failing almost every run. Skipping test on iOS while waiting for a fix in https://trac.webkit.org/changeset/246318/webkit
John Wilander
Comment 3 2019-06-14 18:29:25 PDT
Created attachment 372161 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-06-14 19:22:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 372161 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2019-06-14 19:23:22 PDT
Comment on attachment 372161 [details] Patch for landing Clearing flags on attachment: 372161 Committed r246453: <https://trac.webkit.org/changeset/246453>
WebKit Commit Bot
Comment 6 2019-06-14 19:23:23 PDT
All reviewed patches have been landed. Closing bug.
Shawn Roberts
Comment 8 2019-06-17 13:17:58 PDT
Re opening bug as test is exhibiting the same flaky failure as before.
Russell Epstein
Comment 9 2019-06-18 13:11:20 PDT
Created attachment 372368 [details] Update TestExpectations
Ryan Haddad
Comment 10 2019-06-18 13:43:11 PDT
Comment on attachment 372368 [details] Update TestExpectations Clearing flags on attachment: 372368 Committed r246562: <https://trac.webkit.org/changeset/246562>
Kate Cheney
Comment 11 2019-10-16 17:55:06 PDT
Created attachment 381141 [details] Patch
youenn fablet
Comment 12 2019-10-17 02:22:56 PDT
Comment on attachment 381141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381141&action=review > LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:241 > + testRunner.setStatisticsNotifyPagesWhenDataRecordsWereScanned(true); Is this additional call needed? The testRunner.installStatisticsDidScanDataRecordsCallback call above shoud set it to true.
Kate Cheney
Comment 13 2019-10-17 09:21:31 PDT
Created attachment 381195 [details] Patch
Kate Cheney
Comment 14 2019-10-17 09:21:52 PDT
(In reply to youenn fablet from comment #12) > Comment on attachment 381141 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381141&action=review > > > LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:241 > > + testRunner.setStatisticsNotifyPagesWhenDataRecordsWereScanned(true); > > Is this additional call needed? > The testRunner.installStatisticsDidScanDataRecordsCallback call above shoud > set it to true. Yes you're right, thanks for pointing that out!
WebKit Commit Bot
Comment 15 2019-10-18 09:58:03 PDT
The commit-queue encountered the following flaky tests while processing attachment 381195 [details]: inspector/console/webcore-logging.html bug 203118 (authors: drousso@apple.com and eric.carlson@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 16 2019-10-18 09:58:54 PDT
Comment on attachment 381195 [details] Patch Clearing flags on attachment: 381195 Committed r251287: <https://trac.webkit.org/changeset/251287>
WebKit Commit Bot
Comment 17 2019-10-18 09:58:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.