Bug 197543

Summary:

[WebAuthN] A focused document should be required

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, jiewen_tan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	bfulgham: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews211 for win-future	none
Patch for Landing	jiewen_tan: commit-queue+

Jiewen Tan

Reported 2019-05-02 18:49:48 PDT

A focused document should be required.

Attachments
Patch (4.26 KB, patch) 2019-05-02 19:03 PDT, Jiewen Tan	bfulgham: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.62 MB, application/zip) 2019-05-02 20:04 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.53 MB, application/zip) 2019-05-02 20:48 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews211 for win-future (13.98 MB, application/zip) 2019-05-02 22:22 PDT, EWS Watchlist	no flags	Details
Patch for Landing (12.51 KB, patch) 2019-05-03 12:06 PDT, Jiewen Tan	jiewen_tan: commit-queue+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-05-02 18:50:35 PDT

<rdar://problem/50430989>

Radar WebKit Bug Importer

Comment 2 2019-05-02 18:51:43 PDT Comment hidden (obsolete)

<rdar://problem/50430987>

Jiewen Tan

Comment 3 2019-05-02 19:03:00 PDT

Created attachment 368867 [details] Patch

Brent Fulgham

Comment 4 2019-05-02 19:42:07 PDT

Comment on attachment 368867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171 > - // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator. Why are you removing this comment. At least we should say we aren't implementing these steps and why. > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-243 > - if (!m_client) { Ditto.

EWS Watchlist

Comment 5 2019-05-02 20:04:21 PDT Comment hidden (obsolete)

Comment on attachment 368867 [details] Patch Attachment 368867 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12073209 New failing tests: http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html

EWS Watchlist

Comment 6 2019-05-02 20:04:23 PDT Comment hidden (obsolete)

Created attachment 368876 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-05-02 20:48:31 PDT Comment hidden (obsolete)

Comment on attachment 368867 [details] Patch Attachment 368867 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12073710 New failing tests: http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html

EWS Watchlist

Comment 8 2019-05-02 20:48:32 PDT Comment hidden (obsolete)

Created attachment 368884 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

EWS Watchlist

Comment 9 2019-05-02 22:22:29 PDT Comment hidden (obsolete)

Comment on attachment 368867 [details] Patch Attachment 368867 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12076757 New failing tests: svg/repaint/remove-border-property-on-root.html http/tests/css/filters-on-iframes.html

EWS Watchlist

Comment 10 2019-05-02 22:22:33 PDT Comment hidden (obsolete)

Created attachment 368896 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Jiewen Tan

Comment 11 2019-05-03 11:04:53 PDT

Comment on attachment 368867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review Thanks Brent for r+ this patch. >> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171 >> - // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator. > > Why are you removing this comment. At least we should say we aren't implementing these steps and why. Because all those steps are implemented.

Jiewen Tan

Comment 12 2019-05-03 12:06:10 PDT

Created attachment 368962 [details] Patch for Landing

Jiewen Tan

Comment 13 2019-05-03 16:41:42 PDT

Committed r244938: <https://trac.webkit.org/changeset/244938>

Note You need to log in before you can comment on or make changes to this bug.